Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YBjnktMpSchbnnJc@mwanda>
In-Reply-To: <YBjnktMpSchbnnJc@mwanda>
From:   David Wysochanski <dwysocha@redhat.com>
Date:   Tue, 2 Feb 2021 07:23:47 -0500
Message-ID: <CALF+zOniMjjSCzdh3nLxq9YSbB9Ji7GLA=qRVgVvm2cTRWnkaQ@mail.gmail.com>
Subject: Re: [bug report] NFS: Convert to the netfs API and nfs_readpage to
 use netfs_readpage
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     linux-nfs <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 2, 2021 at 12:48 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Hello Dave Wysochanski,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch bc6d7b12e4ea: "NFS: Convert to the netfs API and
> nfs_readpage to use netfs_readpage" from Nov 14, 2020, leads to the
> following Smatch complaint:
>
>     fs/nfs/read.c:365 nfs_readpage()
>     error: we previously assumed 'file' could be null (see line 356)
>
> fs/nfs/read.c
>    355
>    356          if (file == NULL) {
>                     ^^^^^^^^^^^^
> "file" is NULL here
>
>    357                  ret = -EBADF;
>    358                  desc.ctx = nfs_find_open_context(inode, NULL, FMODE_READ);
>    359                  if (desc.ctx == NULL)
>    360                          goto out_unlock;
>    361          } else
>    362                  desc.ctx = get_nfs_open_context(nfs_file_open_context(file));
>    363
>    364          if (!IS_SYNC(inode)) {
>    365                  ret = nfs_readpage_from_fscache(file, page, &desc);
>                                                         ^^^^
> Unchecked dereference inside function call.
>

Thanks for flagging this.

I confess I don't understand why we could get file == NULL in
nfs_readpage() but I'm looking into it.


>    366                  if (ret == 0)
>    367                          goto out;
>
> regards,
> dan carpenter
>