Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1382954pxb; Thu, 4 Feb 2021 11:27:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5tf9DmkIqgExhR7rDej5eQO8cEaDu2BH03pYlGITXadVxhtKj4x7Oh8tOsA56U2sJnfzF X-Received: by 2002:aa7:cdc8:: with SMTP id h8mr149829edw.244.1612466850501; Thu, 04 Feb 2021 11:27:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612466850; cv=none; d=google.com; s=arc-20160816; b=dcZgWQ+jOuYsfKKQuYpPagEezEM6xFfv6hOutmorHlG1oOVTydB7xg0/7SkrJ4yiJC ffCWwgLBzMekIrbbOxwNBgheEddktceuNGg5SzqpfkZTOlAur6DEoviLvQ6wPd+Key29 DU6ybYcC7UhhfT2nxGPPLFQBJel3xPBFLua4TzUc6IOxfgeJ2l7klVLhCrnHwgtsag7u 9v3OCvxLgGnG6VIRe3YeP/pB46GSlRNdmwLc3njNhVGRRQAtPQ/nK00LqAviddMbXdgs lr/L+5+eZgbMBcRYoam5pWdU3R/SWbthwnTAhUf2TCTua0Ehj7+nDDKXeBERzlTg/G+Q hNYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=zfa2DKo6Y/ELWxj+dOf2P48uiR6p+8E6jto7qzob6ow=; b=pAbSk0jNzo55gmETtv8WDF2lhxgbKngi6Vzlqxpu4Qtr1trqT+piTn3elLzXmxu22S LPxOVuZM1sHqUfLWePgfFioePJlLeV6bd5qFaClvUcSd0X0+ZWJA7X9fxo6kIjnrP5PL 58ZQQgkJZvpFlNSSdWrgBw0AbxsCRVlYbg9ou8YJuqu9XvFsf4/WbM3HJ0hm5WrWgCfT CAWfjcWIWh2x4cot1dWyEFfNmC4cny8e1SxCaqpx2OcwtxaPfgJ6uWFo3REx3pb90rvv MwYGVTwbW3b48LXnV15B82OlF9q583xhVmLJluKLZ2pQ3KDkvU1Hsl2UAzC1dEWpvbQZ oT2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si3541543ejy.605.2021.02.04.11.27.06; Thu, 04 Feb 2021 11:27:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237089AbhBDRHm (ORCPT + 99 others); Thu, 4 Feb 2021 12:07:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:54496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238204AbhBDRAN (ORCPT ); Thu, 4 Feb 2021 12:00:13 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 054E064F3C; Thu, 4 Feb 2021 16:59:32 +0000 (UTC) Subject: [PATCH v4 6/6] rpcrdma: Capture bytes received in Receive completion tracepoints From: Chuck Lever To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Date: Thu, 04 Feb 2021 11:59:32 -0500 Message-ID: <161245797223.737759.5121223683890760045.stgit@manet.1015granger.net> In-Reply-To: <161245786674.737759.8361822825753388908.stgit@manet.1015granger.net> References: <161245786674.737759.8361822825753388908.stgit@manet.1015granger.net> User-Agent: StGit/0.23-29-ga622f1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Make it easier to spot messages of an unusual size. Signed-off-by: Chuck Lever Acked-by: Tom Talpey --- include/trace/events/rpcrdma.h | 50 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/include/trace/events/rpcrdma.h b/include/trace/events/rpcrdma.h index 76e85e16854b..c838e7ac1c2d 100644 --- a/include/trace/events/rpcrdma.h +++ b/include/trace/events/rpcrdma.h @@ -60,6 +60,51 @@ DECLARE_EVENT_CLASS(rpcrdma_completion_class, ), \ TP_ARGS(wc, cid)) +DECLARE_EVENT_CLASS(rpcrdma_receive_completion_class, + TP_PROTO( + const struct ib_wc *wc, + const struct rpc_rdma_cid *cid + ), + + TP_ARGS(wc, cid), + + TP_STRUCT__entry( + __field(u32, cq_id) + __field(int, completion_id) + __field(u32, received) + __field(unsigned long, status) + __field(unsigned int, vendor_err) + ), + + TP_fast_assign( + __entry->cq_id = cid->ci_queue_id; + __entry->completion_id = cid->ci_completion_id; + __entry->status = wc->status; + if (wc->status) { + __entry->received = 0; + __entry->vendor_err = wc->vendor_err; + } else { + __entry->received = wc->byte_len; + __entry->vendor_err = 0; + } + ), + + TP_printk("cq.id=%u cid=%d status=%s (%lu/0x%x) received=%u", + __entry->cq_id, __entry->completion_id, + rdma_show_wc_status(__entry->status), + __entry->status, __entry->vendor_err, + __entry->received + ) +); + +#define DEFINE_RECEIVE_COMPLETION_EVENT(name) \ + DEFINE_EVENT(rpcrdma_receive_completion_class, name, \ + TP_PROTO( \ + const struct ib_wc *wc, \ + const struct rpc_rdma_cid *cid \ + ), \ + TP_ARGS(wc, cid)) + DECLARE_EVENT_CLASS(xprtrdma_reply_class, TP_PROTO( const struct rpcrdma_rep *rep @@ -838,7 +883,8 @@ TRACE_EVENT(xprtrdma_post_linv_err, ** Completion events **/ -DEFINE_COMPLETION_EVENT(xprtrdma_wc_receive); +DEFINE_RECEIVE_COMPLETION_EVENT(xprtrdma_wc_receive); + DEFINE_COMPLETION_EVENT(xprtrdma_wc_send); DEFINE_COMPLETION_EVENT(xprtrdma_wc_fastreg); DEFINE_COMPLETION_EVENT(xprtrdma_wc_li); @@ -1790,7 +1836,7 @@ TRACE_EVENT(svcrdma_post_recv, ) ); -DEFINE_COMPLETION_EVENT(svcrdma_wc_receive); +DEFINE_RECEIVE_COMPLETION_EVENT(svcrdma_wc_receive); TRACE_EVENT(svcrdma_rq_post_err, TP_PROTO(