Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] mountd: Add debug processing from nfs.conf
To:     NeilBrown <neil@brown.name>,
        Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20210201230147.45593-1-steved@redhat.com>
 <20210201230147.45593-2-steved@redhat.com>
 <87y2fzcsfc.fsf@notabene.neil.brown.name>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <66fbe743-aa9d-ca60-8955-c2859d9ab9df@RedHat.com>
Date:   Mon, 8 Feb 2021 12:44:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <87y2fzcsfc.fsf@notabene.neil.brown.name>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/7/21 7:30 PM, NeilBrown wrote:
> On Mon, Feb 01 2021, Steve Dickson wrote:
> 
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>>  nfs.conf              | 2 +-
>>  utils/mountd/mountd.c | 3 +++
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/nfs.conf b/nfs.conf
>> index 186a5b19..9fcf1bf0 100644
>> --- a/nfs.conf
>> +++ b/nfs.conf
>> @@ -30,7 +30,7 @@
>>  # udp-port=0
>>  #
>>  [mountd]
>> -# debug=0
>> +# debug="all|auth|call|general|parse"
>>  # manage-gids=n
>>  # descriptors=0
>>  # port=0
>> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
>> index 988e51c5..a480265a 100644
>> --- a/utils/mountd/mountd.c
>> +++ b/utils/mountd/mountd.c
>> @@ -684,6 +684,9 @@ read_mount_conf(char **argv)
>>  	if (s && !state_setup_basedir(argv[0], s))
>>  		exit(1);
>>  
>> +	if ((s = conf_get_str("mountd", "debug")) != NULL)
>> +		xlog_sconfig(s, 1);
>> +
> 
> Why is this needed?
> A few lines higher up is
>   	xlog_from_conffile("mountd");
> which calls
>  	kinds = conf_get_list(service, "debug");
> and passes each word that it finds to xlog_sconfig()
> ??
> 
> I just tested setting "debug=all" in the mountd section of nfs.conf,
> and it seems to work without this patch.
No it is not... I didn't realize xlog_from_conffile() process
the debug config variable... maybe we should change the name
to something like xlog_debug_conffile()... something more
descriptive as to what it does.

I will clean it up... in a bit.

steved.
> 
> Thanks,
> NeilBrown
> 
> 
>>  	/* NOTE: following uses "nfsd" section of nfs.conf !!!! */
>>  	if (conf_get_bool("nfsd", "udp", NFSCTL_UDPISSET(_rpcprotobits)))
>>  		NFSCTL_UDPSET(_rpcprotobits);
>> -- 
>> 2.29.2