Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Feb 2021 14:13:36 +0000 (GMT)
From:   Daire Byrne <daire@dneg.com>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Trond Myklebust <trondmy@hammerspace.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        "J. Bruce Fields" <bfields@redhat.com>
Message-ID: <285652682.9476664.1613312016960.JavaMail.zimbra@dneg.com>
In-Reply-To: <4CD2739A-D39B-48C9-BCCF-A9DF1047D507@oracle.com>
References: <20210213202532.23146-1-trondmy@kernel.org> <952C605B-C072-4C6B-B9C0-88C25A3B891E@oracle.com> <f025fa709f923255b9cb8e76a9b5ad4cca9355c4.camel@hammerspace.com> <4CD2739A-D39B-48C9-BCCF-A9DF1047D507@oracle.com>
Subject: Re: [PATCH] SUNRPC: Use TCP_CORK to optimise send performance on
 the server
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: SUNRPC: Use TCP_CORK to optimise send performance on the server
Thread-Index: AQHXAkZmunoZe40LXUmxO15yQAmlIKpWoMoAgAAEs4CAABZCgMgY7/PB
Precedence: bulk


----- On 13 Feb, 2021, at 23:30, Chuck Lever chuck.lever@oracle.com wrote:

>> I don't have a performance system to measure the improvement
>> accurately.
> 
> Then let's have Daire try it out, if possible.

I'm happy to test it out on one of our 2 x 40G NFS servers with 100 x 1G clients (but it's trickier to patch the clients too atm).

Just so I'm clear, this is in addition to Chuck's "Handle TCP socket sends with kernel_sendpage() again" patch from bz #209439 (which I think is now in 5.11 rc)? Or you want to see what this patch looks like on it's own without that (e.g. v5.10)?

Daire