Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Daire Byrne <daire@dneg.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Bruce Fields <bfields@redhat.com>
Subject: Re: [PATCH] SUNRPC: Use TCP_CORK to optimise send performance on the
 server
Thread-Topic: [PATCH] SUNRPC: Use TCP_CORK to optimise send performance on the
 server
Thread-Index: AQHXAkZmunoZe40LXUmxO15yQAmlIKpWoMoAgAAEs4CAABZCgMgY7/PBt+g1IgA=
Date:   Sun, 14 Feb 2021 16:59:01 +0000
Message-ID: <E39E6630-91A9-48DA-A6CF-6AE5BF6CEDD1@oracle.com>
References: <20210213202532.23146-1-trondmy@kernel.org>
 <952C605B-C072-4C6B-B9C0-88C25A3B891E@oracle.com>
 <f025fa709f923255b9cb8e76a9b5ad4cca9355c4.camel@hammerspace.com>
 <4CD2739A-D39B-48C9-BCCF-A9DF1047D507@oracle.com>
 <285652682.9476664.1613312016960.JavaMail.zimbra@dneg.com>
In-Reply-To: <285652682.9476664.1613312016960.JavaMail.zimbra@dneg.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3197FA1509371247BBBB1508CAADEFD5@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c755185b-5c5d-424a-5128-08d8d109d43c
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2021 16:59:01.6915
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hlzwkMIBjtDbyY8cePUh4vvDW2brIST4qiv8jI+neqpglNx04Bo1PilSiFiCmv7zKreC3HUrYHqqjg7Upee+mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4814
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9895 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102140145
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9895 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1011 impostorscore=0
 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0
 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102140145
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 14, 2021, at 9:13 AM, Daire Byrne <daire@dneg.com> wrote:
>=20
>=20
> ----- On 13 Feb, 2021, at 23:30, Chuck Lever chuck.lever@oracle.com wrote=
:
>=20
>>> I don't have a performance system to measure the improvement
>>> accurately.
>>=20
>> Then let's have Daire try it out, if possible.
>=20
> I'm happy to test it out on one of our 2 x 40G NFS servers with 100 x 1G =
clients (but it's trickier to patch the clients too atm).

Yes, that's exactly what we need. Thank you!


> Just so I'm clear, this is in addition to Chuck's "Handle TCP socket send=
s with kernel_sendpage() again" patch from bz #209439 (which I think is now=
 in 5.11 rc)? Or you want to see what this patch looks like on it's own wit=
hout that (e.g. v5.10)?

Please include the "Handle TCP socket sends with kernel_sendpage() again" f=
ix.
Or, you can pull a recent stable kernel, I think that fix is already in the=
re.

--
Chuck Lever