Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Feb 2021 15:17:28 -0500
From:   Bruce Fields <bfields@fieldses.org>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     "open list:NFS, SUNRPC, AND..." <linux-nfs@vger.kernel.org>
Subject: Re: pynfs breakage
Message-ID: <20210215201728.GC30742@fieldses.org>
References: <804830ba7fdd91cbf9348050b07f9922801d20f0.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <804830ba7fdd91cbf9348050b07f9922801d20f0.camel@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Mon, Feb 15, 2021 at 03:15:08PM -0500, Jeff Layton wrote:
> Hi Bruce!
> 
> The latest HEAD in pynfs doesn't run for me:
> 
> $ ./nfs4.1/testserver.py --help
> Traceback (most recent call last):
>   File "/home/jlayton/git/pynfs/nfs4.1/./testserver.py", line 38, in <module>
>     import server41tests.environment as environment
>   File "/home/jlayton/git/pynfs/nfs4.1/server41tests/environment.py", line 593
>     def write_file(sess, file, data, offset=0 stateid=stateid4(0, b''),
>                                               ^
> SyntaxError: invalid syntax
> 
> If I revert this commit, then it works:

Yeah, sorry about that, I pushed out quickly thinking I'd tested it, but
in fact it has a bunch of mistakes.  Fixing....

--b.

> 
> commit 49ae5ba83dd98936b3f5c24431a166866b70f34a (HEAD -> master, origin/master, origin/HEAD)
> Author: J. Bruce Fields <bfields@redhat.com>
> Date:   Thu Feb 11 16:22:58 2021 -0500
> 
>     nfs41: read_file and write_file helpers
>     
>     A couple simple helpers copied from 4.0.
>     
>     Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> 
> 
> Cheers,
> -- 
> Jeff Layton <jlayton@kernel.org>