Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5591860pxb;
        Tue, 16 Feb 2021 02:29:36 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzC0HRolNb2Sgj2SDSpiEf//FVggNhZEOsHkPTu7wmQZr00hILZjSf9kqMKFjkB1ai+hMIq
X-Received: by 2002:a17:906:8442:: with SMTP id e2mr19669111ejy.88.1613471376020;
        Tue, 16 Feb 2021 02:29:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1613471376; cv=none;
        d=google.com; s=arc-20160816;
        b=eL5KLvYDsxykSqpEwOUasTAf4xzTmnhoVxKyTjRnbSLgyZd++2suFfoqfxWpoN7D2x
         5koRvKn+8nuojeBu5fCduuaQNjTV5Xh3c+8i6vyb8K5aIX6qsG0LC1nBf18eRXbCh1VC
         3BZpV4TqIt+whLZneSJohsymubjEFwD3/ku9fAVGS47mCTAH1kCgF3f4mukHiI3aHiip
         E1AAT33YWr8niQ36KLkPTR9lfxrlNBjwleaPq+iyP3tq4XbBtEUYkWu0G03r8BWXST1S
         C8gu8nX+9OJAwl3lE7W58PVU8ZlThZL9oRn+iJfgcWfM01v1IVzyuEPIjIzPzSa/bKnT
         sigA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=Lt1eE9/77Ze70np1fzWmjdYAEU9eonYq1Lqs907gnh8=;
        b=JLlUFavi9bapjzvrDq1qfRA3vJAXdE8fOxFUhusF/ww77SGb0WCc68yv3TYJJb2MWW
         Nv2x70c7SN2Ds2pVfzSLcLr3RBGg7Cm+I1WsODrz6QYZsd0YCNG143InG5bE0eglQUBl
         Va8ShYXWrROYr0mPEMCY0yrGjriHHPWbOUVPlYiC5KRYlI620E3+Ivn52nJR2xx7p6yk
         i6h3dDTF+4i+6Rqv3Wvni9W4q7uqlK9Nbigz9c20OwhfVBQoq2LwLIjDeqviQMQakHXx
         /+rajwsobgZybVdBx4WspfTcdpCAcs57IyJMSsKDeWELuSTbcnrppQmuMZjl3kjknWLO
         PG5Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id hx7si13840142ejc.316.2021.02.16.02.29.12;
        Tue, 16 Feb 2021 02:29:36 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230018AbhBPK1u (ORCPT <rfc822;geliangtang@gmail.com>
        + 99 others); Tue, 16 Feb 2021 05:27:50 -0500
Received: from verein.lst.de ([213.95.11.211]:40746 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229809AbhBPK1m (ORCPT <rfc822;linux-nfs@vger.kernel.org>);
        Tue, 16 Feb 2021 05:27:42 -0500
Received: by verein.lst.de (Postfix, from userid 2407)
        id EDE4F67373; Tue, 16 Feb 2021 11:26:59 +0100 (CET)
Date:   Tue, 16 Feb 2021 11:26:59 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     David Howells <dhowells@redhat.com>
Cc:     Trond Myklebust <trondmy@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Steve French <sfrench@samba.org>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@lst.de>, linux-mm@kvack.org,
        linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
        linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
        ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@redhat.com>,
        David Wysochanski <dwysocha@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/33] mm: Add an unlock function for
 PG_private_2/PG_fscache
Message-ID: <20210216102659.GA27714@lst.de>
References: <161340385320.1303470.2392622971006879777.stgit@warthog.procyon.org.uk> <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

> +extern void unlock_page_private_2(struct page *page);

No need for the extern.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>