Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7536351pxb; Thu, 18 Feb 2021 12:46:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvG1QBQ1PDf+2bcGnFwScfWXmQM+CkGYhXwonJTkxKF+FSsH08LAIqs+Z1xbvfrg+yNbFQ X-Received: by 2002:a17:906:fc5:: with SMTP id c5mr5519132ejk.538.1613681182517; Thu, 18 Feb 2021 12:46:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613681182; cv=none; d=google.com; s=arc-20160816; b=LZ6XSBO+wmoIFVFRuVDZOZgLdwUy2EU/xK8y5rUCXgSOn5Za5fjIzy5pGA7wBwb0wV e2oQcQ55fCKqdUWYGxB+dTKkKucPwaKwSt4ThRt7sxpuf9UD1Y7IfLXWdeDybtL95r0w YwIiEoqijf2RlrW6U9NQR9nG2jrp5VBTUOrYr+xLQ52Qb9OD/gcz9QIH8bjEWzG824Ys SOlhv/snnRfDMzaDmZIjQVNAog8n7huhifCntHPtDRaxhDJqttp3oMG1PdlE3Tn3XuFg QPb5k6jI2ynQLoEcRfScvfyL90GeSNffYVrUHHl2HPe8wt292CUx1l7FIL72sKm7dGP1 CcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cFyQNASifwQpMLri08Ol4P6yp5dFeoJ6Rz1w04iex40=; b=SnbTB0IZ0VIioBOU9w5T+7QtKn42BsXflifpfohBeR6Os60fd6aJ6slt/BB+aUvBNS bmzpOnyOizl4WJvlclosKz46Lrfn3Gt80xbrR1c13xgBOu4ReenECdq7+BHoqdBKQ6oD BU5uU5nYAIA2fdKdIdVf7QCCgwwqOXwsaOYhbircJ+Dd8nA5gFpzKGRhXA7fYjEiPa5F 3czRidvLiGgMhI2Ye5QL1b0aKBKdhU4mfon2okFwdmC670EUdKH9fnfWMkwyjj+UEm5G vctq5Tl4n7kijfreBtrS7VKpQ4mvHzqAQyk+xbqKA62LLklbxED3cCwmVQRWb465LZGg vL/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ad9xrVWw; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si4208232edz.497.2021.02.18.12.45.48; Thu, 18 Feb 2021 12:46:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ad9xrVWw; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbhBRUnw (ORCPT + 99 others); Thu, 18 Feb 2021 15:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhBRUlp (ORCPT ); Thu, 18 Feb 2021 15:41:45 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31AEC0617AA; Thu, 18 Feb 2021 12:41:22 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id r23so8224156ljh.1; Thu, 18 Feb 2021 12:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cFyQNASifwQpMLri08Ol4P6yp5dFeoJ6Rz1w04iex40=; b=ad9xrVWwPRJ0Op7IrKvZt0bJXunRvSzb1OGuouK5C/8+63N00msV3K1hURk0ID3R/t ssl6CA+hTMPJX/9Sr62yXSmtN/nkX7ytk1DTXwRHAplmTCj+7VQfEoFCAngSsig6xVOM wafKbDXUw5R9Ib/vN/DgZ2ijnRTaOkMnqgYalC2c0B/3kC9SpKIHNqQGWw3lnfYzPieO zac3ULzHVUiS/CzUScmj8giO7bJNLSWKbHHHzOKPKI6SH4VnXmkz+2bIatpm+3JaeGTu 0WNWTxias5zgTTvhLwQyhUtog6ElixtiMQk/UqeRbfJJotEBLzgTg1hkhOl8WsdwHQQR dQIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cFyQNASifwQpMLri08Ol4P6yp5dFeoJ6Rz1w04iex40=; b=IMF8hs1ANiNwmmUFisKxbbZcTs+pQ+kfsHDs8++sSHLy/jlSsBwAJoXyzvygKN+heD k+xnaHDu6WxjomuAF89rbDswEt8YRHMi/rzHMFoxNihgeo03580KMcnRFQm+XPUsZsvB 2vKG6iVHYzUJbCAtD9E1Qr/is0AGu04GiW4oFA2KfVh/iOj6E+rdqxaOopRkl6Gr4G2Z ENEYiOSD6HFdvw219NDo/Q9MyM0NsRpAbu/fDEFooX8tlNZIAQwrD0oWmU0ZGrKmfxA9 RLCIFSzAXDRgeKagtGf8R24L8RjrT8lCOk5w1Bwq7G+Vs8MKHf6zo98MlhLFAty61GLN DggA== X-Gm-Message-State: AOAM531vCEE26Ho44XL5x4SyY5MZW0KrH/EtrzKIbal+7RsaaZuBdQTz OYUTeMBfZ33cqzpEbuC64J7PZmHD+PAtw7b4WZI= X-Received: by 2002:a05:6512:1311:: with SMTP id x17mr3289191lfu.307.1613680881337; Thu, 18 Feb 2021 12:41:21 -0800 (PST) MIME-Version: 1.0 References: <20210215154317.8590-1-lhenriques@suse.de> <20210218074207.GA329605@infradead.org> In-Reply-To: From: Steve French Date: Thu, 18 Feb 2021 14:41:10 -0600 Message-ID: Subject: Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices To: Amir Goldstein Cc: Christoph Hellwig , Luis Henriques , Jeff Layton , Steve French , Miklos Szeredi , Trond Myklebust , Anna Schumaker , Alexander Viro , "Darrick J. Wong" , Dave Chinner , Greg KH , Nicolas Boichat , Ian Lance Taylor , Luis Lozano , ceph-devel , linux-kernel , CIFS , samba-technical , linux-fsdevel , Linux NFS Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Feb 18, 2021 at 4:03 AM Amir Goldstein wrote: > > On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig wrote: > > > > Looks good: > > > > Reviewed-by: Christoph Hellwig > > > > This whole idea of cross-device copie has always been a horrible idea, > > and I've been arguing against it since the patches were posted. > > Ok. I'm good with this v2 as well, but need to add the fallback to > do_splice_direct() > in nfsd_copy_file_range(), because this patch breaks it. Interestingly, for ksmbd (cifsd) looks like they already do splice not copy_file_range -- Thanks, Steve