Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Feb 2021 15:59:37 -0500
To:     trondmy@kernel.org
Cc:     "J. Bruce Fields" <bfields@redhat.com>,
        Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Don't keep looking up unhashed files in the nfsd
 file cache
Message-ID: <20210224205937.GH11591@fieldses.org>
References: <20210219020207.688592-1-trondmy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210219020207.688592-1-trondmy@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
From:   bfields@fieldses.org (J. Bruce Fields)
Precedence: bulk

On Thu, Feb 18, 2021 at 09:02:07PM -0500, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> If a file is unhashed, then we're going to reject it anyway and retry,
> so make sure we skip it when we're doing the RCU lockless lookup.
> This avoids a number of unnecessary nfserr_jukebox returns from
> nfsd_file_acquire()

Looks good to me.--b.

> 
> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>  fs/nfsd/filecache.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 53fcbf79bdca..7629248fdd53 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -898,6 +898,8 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags,
>  			continue;
>  		if (!nfsd_match_cred(nf->nf_cred, current_cred()))
>  			continue;
> +		if (!test_bit(NFSD_FILE_HASHED, &nf->nf_flags))
> +			continue;
>  		if (nfsd_file_get(nf) != NULL)
>  			return nf;
>  	}
> -- 
> 2.29.2