Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>,
        "trondmy@kernel.org" <trondmy@kernel.org>
CC:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Don't keep looking up unhashed files in the nfsd
 file cache
Thread-Topic: [PATCH] nfsd: Don't keep looking up unhashed files in the nfsd
 file cache
Thread-Index: AQHXBmM9AsfFb3XoEEuds5U8G7v31qpn0yWAgAAAggA=
Date:   Wed, 24 Feb 2021 21:01:27 +0000
Message-ID: <F0281F96-9D2C-4461-BA5F-37FD1A23A425@oracle.com>
References: <20210219020207.688592-1-trondmy@kernel.org>
 <20210224205937.GH11591@fieldses.org>
In-Reply-To: <20210224205937.GH11591@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89F86B698940F64FB6573ED0D932EE1C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ef464442-4131-4e39-4b4a-08d8d9075a2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 21:01:27.3090
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ypeF/E9lod35Bn2WmI/4YRnfAAUCalgDIzIRFDCiaghSqBC5caG7iVVEmHkM7eBSWXCQqmDQxAFHDWiG7uQFRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3921
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9905 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=920 adultscore=0 bulkscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102240163
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9905 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 priorityscore=1501
 clxscore=1015 impostorscore=0 lowpriorityscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102240163
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 24, 2021, at 3:59 PM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> On Thu, Feb 18, 2021 at 09:02:07PM -0500, trondmy@kernel.org wrote:
>> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>>=20
>> If a file is unhashed, then we're going to reject it anyway and retry,
>> so make sure we skip it when we're doing the RCU lockless lookup.
>> This avoids a number of unnecessary nfserr_jukebox returns from
>> nfsd_file_acquire()
>=20
> Looks good to me.--b.

Thanks for the review. This is now included in the for-rc topic branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


>> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nf=
sd")
>> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>> ---
>> fs/nfsd/filecache.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>=20
>> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
>> index 53fcbf79bdca..7629248fdd53 100644
>> --- a/fs/nfsd/filecache.c
>> +++ b/fs/nfsd/filecache.c
>> @@ -898,6 +898,8 @@ nfsd_file_find_locked(struct inode *inode, unsigned =
int may_flags,
>> 			continue;
>> 		if (!nfsd_match_cred(nf->nf_cred, current_cred()))
>> 			continue;
>> +		if (!test_bit(NFSD_FILE_HASHED, &nf->nf_flags))
>> +			continue;
>> 		if (nfsd_file_get(nf) !=3D NULL)
>> 			return nf;
>> 	}
>> --=20
>> 2.29.2

--
Chuck Lever