Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Julian Braha <julianbraha@gmail.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsd: fix kconfig dependency warning for NFSD_V4
Thread-Topic: [PATCH] nfsd: fix kconfig dependency warning for NFSD_V4
Thread-Index: AQHXCvExg0cHIUazCEiSB9E8F7y8OA==
Date:   Wed, 24 Feb 2021 21:08:27 +0000
Message-ID: <989596C7-645F-4D4E-92D6-62547961A9FE@oracle.com>
References: <4276512.Scm06nC1gK@ubuntu-mate-laptop>
In-Reply-To: <4276512.Scm06nC1gK@ubuntu-mate-laptop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5BB1BDC5172B1C40AE8C7F1BADA49859@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 38921855-dc6f-4445-fa18-08d8d9085461
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 21:08:27.0960
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NhBM8BXwZ9YNpXSiHRdpPU2ZduIbRnFT1tDGEFWDk5A4QZkyG8XrSqkrrl2ESr91Ie91u88kEPlpF0gZ9oDQhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2872
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9905 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102240164
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9905 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 malwarescore=0
 clxscore=1011 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102240164
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Julian-

> On Feb 19, 2021, at 4:56 PM, Julian Braha <julianbraha@gmail.com> wrote:
>=20
> When NFSD_V4 is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>=20
> WARNING: unmet direct dependencies detected for CRYPTO_SHA256
>  Depends on [n]: CRYPTO [=3Dn]
>  Selected by [y]:
>  - NFSD_V4 [=3Dy] && NETWORK_FILESYSTEMS [=3Dy] && NFSD [=3Dy] && PROC_FS=
 [=3Dy]
>=20
> WARNING: unmet direct dependencies detected for CRYPTO_MD5
>  Depends on [n]: CRYPTO [=3Dn]
>  Selected by [y]:
>  - NFSD_V4 [=3Dy] && NETWORK_FILESYSTEMS [=3Dy] && NFSD [=3Dy] && PROC_FS=
 [=3Dy]
>=20
> This is because NFSD_V4 selects CRYPTO_MD5 and CRYPTO_SHA256,
> without depending on or selecting CRYPTO, despite those config options
> being subordinate to CRYPTO.
>=20
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

I've included this patch in the for-rc topic branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

However, there was some harumphing over on linux-rdma about
a similar change for CRYPTO_CRC32 and the rxe driver. I'm
not quite clear about the outcome of that conversation. It
seems like we are going with either

 - add "select CRYPTO"

or

 - add "depends on CRYPTO"


> --- a/fs/nfsd/Kconfig 2021-02-09 22:05:29.462030761 -0500
> +++ b/fs/nfsd/Kconfig 2021-02-11 12:00:48.974076992 -0500
> @@ -73,6 +73,7 @@
>   select NFSD_V3
>   select FS_POSIX_ACL
>   select SUNRPC_GSS
> + select CRYPTO
>   select CRYPTO_MD5
>   select CRYPTO_SHA256
>   select GRACE_PERIOD
>=20
>=20

--
Chuck Lever