Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dKO7GnsPekgSoofHTpDkxvNtFgqIYGdlMf7rNmG2qdZuQVwmGBh78Zzwi0kbePO1TGJjYLePgK
 9ZLoJELIdXtOLF7sKE+oFFTNbnhKYhm7XhunC47uH8FsRmgGTku+Hj2wFq+oG0i7I54c+dwnGV
 TtGdbEu1Cbw5QjTg2WxXXUleBg9X82BrB1An8Uyq17pSIgowP6dSdmQhtoPLvge868Pvyycr0e
 NEbNLQ1/dWV/92ogGEt+f9ae9Ob/gBQBvj8DSsuiNoqP1vSm3EcgvFJlc5w3W/jkqz7n0gJIdn
 QgE=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     "hch@infradead.org" <hch@infradead.org>,
        Jens Axboe <axboe@kernel.dk>
CC:     Stefan Hajnoczi <stefanha@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "dm-devel@redhat.com" <dm-devel@redhat.com>,
        "fujita.tomonori@lab.ntt.co.jp" <fujita.tomonori@lab.ntt.co.jp>,
        "tim@cyberelk.net" <tim@cyberelk.net>,
        "mst@redhat.com" <mst@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "bp@alien8.de" <bp@alien8.de>, "agk@redhat.com" <agk@redhat.com>,
        "snitzer@redhat.com" <snitzer@redhat.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "dgilbert@interlog.com" <dgilbert@interlog.com>,
        "Kai.Makisara@kolumbus.fi" <Kai.Makisara@kolumbus.fi>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        Avri Altman <Avri.Altman@wdc.com>,
        "bfields@fieldses.org" <bfields@fieldses.org>,
        "chuck.lever@oracle.com" <chuck.lever@oracle.com>,
        "baolin.wang@linaro.org" <baolin.wang@linaro.org>,
        "vbadigan@codeaurora.org" <vbadigan@codeaurora.org>,
        "zliua@micron.com" <zliua@micron.com>,
        "richard.peng@oppo.com" <richard.peng@oppo.com>,
        "guoqing.jiang@cloud.ionos.com" <guoqing.jiang@cloud.ionos.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>
Subject: Re: [RFC PATCH] blk-core: remove blk_put_request()
Thread-Topic: [RFC PATCH] blk-core: remove blk_put_request()
Thread-Index: AQHXCV9JZjwro7cFh0S/a18Ze28sQg==
Date:   Thu, 25 Feb 2021 02:01:22 +0000
Message-ID: <BYAPR04MB4965BC5C807658B3B433364A869E9@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20210222211115.30416-1-chaitanya.kulkarni@wdc.com>
 <YDY+ObNNiBMMuSEt@stefanha-x1.localdomain>
 <f3141eb3-9938-a216-a9f8-cb193589a657@kernel.dk>
 <20210224185521.GA2326119@infradead.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 56f64fd6-2cdc-4abd-c521-08d8d9314028
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2021 02:01:22.4144
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f4h07uujdgDMaaLd+E6bOJvg9EKRXI8nL3l5DC6R3D4oFAfvDFXOiwV8CiczABQqDfr6y0PDGXBQhUjggbo4Jw3CwrTBGIPr7xseE97cCEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7501
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 2/24/21 10:56, Christoph Hellwig wrote:=0A=
> On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:=0A=
>> Would make sense to rename blk_get_request() to blk_mq_alloc_request()=
=0A=
>> and then we have API symmetry. The get/put don't make sense when there=
=0A=
>> are no references involved.=0A=
>>=0A=
>> But it's a lot of churn for very little reward, which is always kind=0A=
>> of annoying. Especially for the person that has to carry the patches.=0A=
> Let's do the following:=0A=
>=0A=
>  - move the initialize_rq_fn call from blk_get_request into=0A=
>    blk_mq_alloc_request and make the former a trivial alias for the=0A=
>    latter=0A=
>  - migrate to the blk_mq_* versions on a per-driver/subsystem basis.=0A=
>    The scsi migration depends on the first item above, so it will have=0A=
>    to go with that or wait for the next merge window=0A=
>  - don't migrate the legacy ide driver, as it is about to be removed and=
=0A=
>    has a huge number of blk_get_request calls=0A=
>=0A=
=0A=
Okay, thanks for the feedback, will try and get something together.=0A=