Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3326894pxb; Mon, 1 Mar 2021 07:20:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyD6XF9ip7Yx9UWLrFoXjbyHM62wmbelVOC6BXetRENro3nO3UysUXKps351Ayp/f0txKmN X-Received: by 2002:a05:6402:1d1a:: with SMTP id dg26mr10328886edb.266.1614611999961; Mon, 01 Mar 2021 07:19:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614611999; cv=none; d=google.com; s=arc-20160816; b=Mqs1EPIMDiYmKyC3iXmBxYsAuJwC/sKjUQ6ENlkM6RJuHWAZSgi0AHMeUlRhmKK9oi EkduliTg5p5KJVKwQosrVDQUEUpG3qO2pBP9Q623ovCXr0ZGb4qgE8Q57dHvArIstGjR UxU4zoh9XgDpAjqVQnTXg61y7n2DvKWrNtJc3nHAhuzvmzlnt0bYv+gKN48qFfNWtlJk DwuL2HEjqpjSFEYC/34cptb46dZFXzu+BWj0B+NPkr7DyY0mU5s6bZnnNcKpTVapfYe9 c78DSanChW1QjzgQTQSguMisz4IpUHoxmQeaHZzqCJgNjOYjdZjiwbfy8F2QfwBoHDgy 2Ggw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:to:from:subject; bh=IKq69+E5eHYoWIXdbSXIQn/Ze7B7BDitkLLsa2pPM+k=; b=SxrKxc3pIQCJLGzJbbt9Hwt2WEmXY+gzeSzT0UCUsntHrnS6RKjmXtFcWzY2gkWJ/7 sPJ7rgXg0KeBgZq25n/AhdV+OnXGIMXrbI60aALD1KIa+6llFLc3kUmU6fZ6C1jAgsgR BD+arEVRKG2OrDAbHpz1/vkLvlzLulXFM498WyYvBaDV5bRbpCZs0Y60aqVGfJ5S/GmO ksQETdwUqn29huDEMh1HY85Wnvjt/BxanrsJS/JXQtjLFE+8cM55l8COj4kGpX+XbMIq HNB5xwW3wJ703ylICahX8+qD932oVxCu7qKgsmcrft5tygbyGpdwJShihZ1JMzRuQsuH fYqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si11076982eje.450.2021.03.01.07.19.35; Mon, 01 Mar 2021 07:19:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237158AbhCAPTB (ORCPT + 99 others); Mon, 1 Mar 2021 10:19:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:41200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237082AbhCAPSs (ORCPT ); Mon, 1 Mar 2021 10:18:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E179B64E01 for ; Mon, 1 Mar 2021 15:18:07 +0000 (UTC) Subject: [PATCH v1 28/42] NFSD: Update the NFSv2 STATFS result encoder to use struct xdr_stream From: Chuck Lever To: linux-nfs@vger.kernel.org Date: Mon, 01 Mar 2021 10:18:07 -0500 Message-ID: <161461188720.8508.6558067613011265623.stgit@klimt.1015granger.net> In-Reply-To: <161461145466.8508.13379815439337754427.stgit@klimt.1015granger.net> References: <161461145466.8508.13379815439337754427.stgit@klimt.1015granger.net> User-Agent: StGit/1.0-5-g755c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Chuck Lever --- fs/nfsd/nfsxdr.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/fs/nfsd/nfsxdr.c b/fs/nfsd/nfsxdr.c index d6d7d07dbb1b..39d296aecd3e 100644 --- a/fs/nfsd/nfsxdr.c +++ b/fs/nfsd/nfsxdr.c @@ -592,19 +592,26 @@ nfssvc_encode_readdirres(struct svc_rqst *rqstp, __be32 *p) int nfssvc_encode_statfsres(struct svc_rqst *rqstp, __be32 *p) { + struct xdr_stream *xdr = &rqstp->rq_res_stream; struct nfsd_statfsres *resp = rqstp->rq_resp; struct kstatfs *stat = &resp->stats; - *p++ = resp->status; - if (resp->status != nfs_ok) - return xdr_ressize_check(rqstp, p); + if (!svcxdr_encode_stat(xdr, resp->status)) + return 0; + switch (resp->status) { + case nfs_ok: + p = xdr_reserve_space(xdr, XDR_UNIT * 5); + if (!p) + return 0; + *p++ = cpu_to_be32(NFSSVC_MAXBLKSIZE_V2); + *p++ = cpu_to_be32(stat->f_bsize); + *p++ = cpu_to_be32(stat->f_blocks); + *p++ = cpu_to_be32(stat->f_bfree); + *p = cpu_to_be32(stat->f_bavail); + break; + } - *p++ = htonl(NFSSVC_MAXBLKSIZE_V2); /* max transfer size */ - *p++ = htonl(stat->f_bsize); - *p++ = htonl(stat->f_blocks); - *p++ = htonl(stat->f_bfree); - *p++ = htonl(stat->f_bavail); - return xdr_ressize_check(rqstp, p); + return 1; } int