Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 01/42] NFSD: Extract the svcxdr_init_encode() helper
Thread-Topic: [PATCH v1 01/42] NFSD: Extract the svcxdr_init_encode() helper
Thread-Index: AQHXDq46iTwkJHRyYEevA5aYNnyw7Kpw6i+AgAACtIA=
Date:   Tue, 2 Mar 2021 16:57:28 +0000
Message-ID: <C152432E-C7D2-455B-9193-3D020A23E82F@oracle.com>
References: <161461145466.8508.13379815439337754427.stgit@klimt.1015granger.net>
 <161461172449.8508.5387365342766187229.stgit@klimt.1015granger.net>
 <20210302164747.GA3400@fieldses.org>
In-Reply-To: <20210302164747.GA3400@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5F5F38D7B828B043A87BC04B53E1F86D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b2c9b45a-0ad5-4228-da2d-08d8dd9c4352
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 16:57:28.6079
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T+AAOYR4m5ZoyJqeq6HbUqwLof74RP1kCta/yfaEtF/4KDLFT8J5Sw5EK/bZAH1fDpQ9snZhN+KKqhdslQG3bQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3030
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=922
 phishscore=0 bulkscore=0 mlxscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103020130
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501
 mlxlogscore=999 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0
 mlxscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103020130
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 2, 2021, at 11:47 AM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> On Mon, Mar 01, 2021 at 10:15:24AM -0500, Chuck Lever wrote:
>> NFSD initializes an encode xdr_stream only after the RPC layer has
>> already inserted the RPC Reply header.
>=20
> Out of curiosity: does it need to be this way?

The code in svc.c uses the old-school svc_putu32() and friends macros.
I don't think there's another reason.

IMHO they could be replaced, but I didn't have the stones to go that
far.


--
Chuck Lever