Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp993288pxb; Wed, 3 Mar 2021 23:51:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZk3bl/AFMtu86drBXaxvtaiKgPpDjtVw5x//bUXhnNhuWDM5xpUTjRQI9h/s0AsG6S1EJ X-Received: by 2002:a17:906:1dc2:: with SMTP id v2mr2914381ejh.350.1614844272662; Wed, 03 Mar 2021 23:51:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614844272; cv=none; d=google.com; s=arc-20160816; b=PnGJqqQmtbaV41wSs9RPLFLgrQ5R7xT1vldd7bohDqd6QP+Xm8R4Lox+zXF2Ee1gE/ /pgl5mSRBt4gt1/9Ecvwm6cCJu+6GvEL6RVdu22+AQvA1jTmBtPDvnNS6O+grZsowcsR 2gO2GgZzTyrcREt3zJlyJmrWxo06AeDrUkYfJZy0LdKXQaYH6vp5rQHUeJeIydZ3uklE XT8L5dhoYT9a/h+l2cYXZv3lwf5qCGRpQF5WMjpnNfI2vqexPhmRuNN7CSMciVtJDmoU aZp7YdG7637H47u4bcWmqppRGsxrgok9qmPYNBAAFrPsra8LQEqzZ7Ou+7kgNJYtjQEV Q8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pOvwgDCVFoFp8x5o6ZXGiZ7wNi+/BiGbbICIxdJ/OOE=; b=PA+kFRQkueUJyU8uqymlQWcEV8/3Ra+Y+yfSd4L0IHLos160HYwS1+46YZ9NqI0wdo Yvb65/77fE3EU+7lUutvAYg82V6QkJZCjRUSw9H1ov6qIeH+wDCTx/KBuY6/QTQ8H1Ec LMUBPF9KiFHqmjszEtUV8mzuBO8KxndhYEzGC/tzhItKsE8DHbEHfQNBaZLRn+NYblYY ANTvXqtpfbuuazts9M3UPc9OT3tOIaGLaxeQ4jziGUxMwPJ+tFAIuPT6evPfz5BM72G9 52vE3SB9zRwmxbD6kALEyvyIb0v4qAvvC5FNkzrRGBKyy0W2rKFXqWWKP+gDohOYt+T0 wINg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O0YLwfLs; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ks7si8846312ejb.682.2021.03.03.23.50.50; Wed, 03 Mar 2021 23:51:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O0YLwfLs; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245234AbhCCK5J (ORCPT + 99 others); Wed, 3 Mar 2021 05:57:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29689 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350897AbhCBVAT (ORCPT ); Tue, 2 Mar 2021 16:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614718701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pOvwgDCVFoFp8x5o6ZXGiZ7wNi+/BiGbbICIxdJ/OOE=; b=O0YLwfLs2SuNKTgXglaxulKtTaPMK0d+RXcL+MvcTmOWm2BvN3AxKjKxY3URZxqo/Xo4b6 vWsOhhIsNTUOAzqGg49LAUTjqispm1wHUORuVCVj/rcwEBUN6BdhZZoWrAav+jgGTeKAuY 1lUQWzwLvaLqufSETVJdfzqrY20xV4E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-B4XBUjfcPA-CK4UY2sEhnA-1; Tue, 02 Mar 2021 15:58:19 -0500 X-MC-Unique: B4XBUjfcPA-CK4UY2sEhnA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA45510082F5 for ; Tue, 2 Mar 2021 20:58:18 +0000 (UTC) Received: from bearskin.sorenson.redhat.com (ovpn-114-44.phx2.redhat.com [10.3.114.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC2EC6F996; Tue, 2 Mar 2021 20:58:15 +0000 (UTC) From: Frank Sorenson To: linux-nfs@vger.kernel.org Cc: sorenson@redhat.com Subject: [PATCH] NFS: Correct size calculation for create reply length Date: Tue, 2 Mar 2021 14:58:14 -0600 Message-Id: <20210302205814.1228549-1-sorenson@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org CREATE requests return a post_op_fh3, rather than nfs_fh3. The post_op_fh3 includes an extra word to indicate 'handle_follows'. Without that additional word, create fails when full 64-byte filehandles are in use. Add NFS3_post_op_fh_sz, and correct the size calculation for NFS3_createres_sz. Signed-off-by: Frank Sorenson --- fs/nfs/nfs3xdr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c index ca10072644ff..ed1c83738c30 100644 --- a/fs/nfs/nfs3xdr.c +++ b/fs/nfs/nfs3xdr.c @@ -36,6 +36,7 @@ #define NFS3_pagepad_sz (1) /* Page padding */ #define NFS3_fhandle_sz (1+16) #define NFS3_fh_sz (NFS3_fhandle_sz) /* shorthand */ +#define NFS3_post_op_fh_sz (1+NFS3_fh_sz) #define NFS3_sattr_sz (15) #define NFS3_filename_sz (1+(NFS3_MAXNAMLEN>>2)) #define NFS3_path_sz (1+(NFS3_MAXPATHLEN>>2)) @@ -73,7 +74,7 @@ #define NFS3_readlinkres_sz (1+NFS3_post_op_attr_sz+1+NFS3_pagepad_sz) #define NFS3_readres_sz (1+NFS3_post_op_attr_sz+3+NFS3_pagepad_sz) #define NFS3_writeres_sz (1+NFS3_wcc_data_sz+4) -#define NFS3_createres_sz (1+NFS3_fh_sz+NFS3_post_op_attr_sz+NFS3_wcc_data_sz) +#define NFS3_createres_sz (1+NFS3_post_op_fh_sz+NFS3_post_op_attr_sz+NFS3_wcc_data_sz) #define NFS3_renameres_sz (1+(2 * NFS3_wcc_data_sz)) #define NFS3_linkres_sz (1+NFS3_post_op_attr_sz+NFS3_wcc_data_sz) #define NFS3_readdirres_sz (1+NFS3_post_op_attr_sz+2+NFS3_pagepad_sz) -- 2.29.2