Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp994130pxb; Wed, 3 Mar 2021 23:53:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFBSed2vjDzQ51U2seeCdXhov4ll+sSbqE57aMHSbGOD0mfOk3x3jj+hqgCrYRIQ0hCOBl X-Received: by 2002:a17:906:16ca:: with SMTP id t10mr2874709ejd.85.1614844405033; Wed, 03 Mar 2021 23:53:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614844405; cv=none; d=google.com; s=arc-20160816; b=phVECb8fNOJ4rhXfyWY9BjzjODp9/A9Yp69gMHImjJ8R5yOEsXan8Yp2bhVaviSeEa LY8+9eUERVqIQ20Qe0x29XoUprSDfrI9U9K/IV5WH1Em/DBDqz3kUf846vOfGbQfBFQs LZiH8aU9nkAJEz3Q4A1QnOrsM0MIJ3nvGxoCG7Mnd5e/+HJr7VuC6PkeHzOe4Duh5NbT RLDVA8bbCKNnDrP6AYe2hLqzrpF85XRo6TZUpt3pFbsV0EI47se9Mfsj4nTA+jn/fHFW VeDN+CiEV3q/gv8rfLceMxAgkr7leCr9Q/i1IIym4p4obC7cHL53uUuhjo+pIFib331J LS1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=deBjUIw7o+5FrL5cMAMC5oZOFMRRuWN1/zCIz0A/P5I=; b=ivAc1YwuBpqIz6kEftLFNPSPnQnzY+Tiu4GL1Um8dr2OLm0aolW2/u6xKMn0y9kFsI Q3wgRj0OQwhIJxW5zIH1+OnBkeZh7hwa/gvscW0I3docnbpnBti3XNZoAUtvD7vUcwZd 45EHn/WsS9yXKJZJ5lWywWd6o3fWZK9thE6Y9+DKiHsAqmvdqyh72MN13DIm/FskOnxB IE0b4FIU77Fc4ea4w3Z06G8WZGXXrZWrXXulAYajPaPd/dxGy2eKCFgYj2Kn7Q9tLKKQ pthPOcLHVrVbu8CGSyAmWQrP0JYQI9mU3pfBrjr2avzig7KhYFowx1hdcRcIGrPngIC/ 8/kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=bL53yZ+p; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si16452797eje.542.2021.03.03.23.53.02; Wed, 03 Mar 2021 23:53:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=bL53yZ+p; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346472AbhCCK7C (ORCPT + 99 others); Wed, 3 Mar 2021 05:59:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347723AbhCCHOa (ORCPT ); Wed, 3 Mar 2021 02:14:30 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6AECC061756 for ; Tue, 2 Mar 2021 23:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=deBjUIw7o+5FrL5cMAMC5oZOFMRRuWN1/zCIz0A/P5I=; b=bL53yZ+p2+y9M/j7v7JtBh5Cqk ZTAflsO4MCaAffr+25sUsXEOLdiwHpH4XQJY+lv0jZDkot4r2puiJACddPSskVpUceUgNd3yt5EK+ hvWgtLaxESzTAcQolUoJUCqWOzjStgLCJ0lvgFgrWK/uwD6eLhg9EmLUVhhuAc2wYD36lFKqQLpFK CPH02xx99TKjPFMMX1n76xzaWcjA8Cy42/oaW5EQye0ulygkII6/0oOhZZR/jDOP/UKAwdyunX3O3 HovfW6tOLL+0FtbpijStng55BjNPtBMdcyX/my+vz+IVueX+hXCOeZsscLcFvkAXvC8+5Arwb1C+t VVdiCtYw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lHLhZ-001eDF-LO; Wed, 03 Mar 2021 07:13:45 +0000 Date: Wed, 3 Mar 2021 07:13:45 +0000 From: Christoph Hellwig To: Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 14/42] NFSD: Update the NFSv3 PATHCONF3res encoder to use struct xdr_stream Message-ID: <20210303071345.GA388507@infradead.org> References: <161461145466.8508.13379815439337754427.stgit@klimt.1015granger.net> <161461180307.8508.9954286154242416300.stgit@klimt.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161461180307.8508.9954286154242416300.stgit@klimt.1015granger.net> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Mar 01, 2021 at 10:16:43AM -0500, Chuck Lever wrote: > + *p++ = resp->p_no_trunc ? xdr_one : xdr_zero; > + *p++ = resp->p_chown_restricted ? xdr_one : xdr_zero; > + *p++ = resp->p_case_insensitive ? xdr_one : xdr_zero; > + *p = resp->p_case_preserving ? xdr_one : xdr_zero; Wouldn't a little xdr_encode_bool helper for this common pattern be nice?