Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 14/42] NFSD: Update the NFSv3 PATHCONF3res encoder to
 use struct xdr_stream
Thread-Topic: [PATCH v1 14/42] NFSD: Update the NFSv3 PATHCONF3res encoder to
 use struct xdr_stream
Thread-Index: AQHXDq4/0X84eSq3BkC2qT4W0/Xi36px3CKAgACL3oA=
Date:   Wed, 3 Mar 2021 15:34:21 +0000
Message-ID: <DC29E9AB-B152-46F4-87EE-FD329F1DCF6F@oracle.com>
References: <161461145466.8508.13379815439337754427.stgit@klimt.1015granger.net>
 <161461180307.8508.9954286154242416300.stgit@klimt.1015granger.net>
 <20210303071345.GA388507@infradead.org>
In-Reply-To: <20210303071345.GA388507@infradead.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B641531C79135F43AFBAEEB2E9A737EB@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ecb4dbf8-70af-4a83-29c1-08d8de59d144
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2021 15:34:21.6668
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FanHisVDQI6SmxTQ7EDtuCgG1i7dnf9bHP4xmehXYbhRXZgAakAWvi5WoMrFG3N7YCzcbVkj62UXcY06gyWBYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4321
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 mlxscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103030119
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 bulkscore=0
 lowpriorityscore=0 spamscore=0 mlxlogscore=999 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103030119
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 3, 2021, at 2:13 AM, Christoph Hellwig <hch@infradead.org> wrote:
>=20
> On Mon, Mar 01, 2021 at 10:16:43AM -0500, Chuck Lever wrote:
>> +	*p++ =3D resp->p_no_trunc ? xdr_one : xdr_zero;
>> +	*p++ =3D resp->p_chown_restricted ? xdr_one : xdr_zero;
>> +	*p++ =3D resp->p_case_insensitive ? xdr_one : xdr_zero;
>> +	*p =3D resp->p_case_preserving ? xdr_one : xdr_zero;
>=20
> Wouldn't a little xdr_encode_bool helper for this common pattern be
> nice?

Sure. In include/linux/sunrpc/xdr.h, I've now added:

/**
 * xdr_encode_bool - Encode a boolean item
 * @p: address in a buffer into which to encode
 * @n: boolean value to encode
 *
 * Return value:
 *   Address of item following the encoded boolean
 */
static inline __be32 *xdr_encode_bool(__be32 *p, u32 n)
{
       *p =3D n ? xdr_one : xdr_zero;
       return p++;
}

and xdr_stream_encode_bool() has been changed to use this helper.

In fs/nfsd/nfs3xdr.c, the PATHCONF result encoder now uses
xdr_encode_bool() to encode the four boolean fields in struct
PATHCONF3resok.

--
Chuck Lever