Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
CC:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] NFSD: fix error handling in NFSv4.0 callbacks
Thread-Topic: [PATCH v3 1/1] NFSD: fix error handling in NFSv4.0 callbacks
Thread-Index: AQHXFRFWtrI7LwxgJU2zGAdgZmQJpap8CSiA
Date:   Tue, 9 Mar 2021 19:23:13 +0000
Message-ID: <EAC51290-2EB8-4FE1-BD37-AE035D7BCB6C@oracle.com>
References: <20210309182337.62308-1-olga.kornievskaia@gmail.com>
In-Reply-To: <20210309182337.62308-1-olga.kornievskaia@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EBA2F6ED67453B41A3EEC4ACE39B0ABF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca62073-c52a-4023-8fd8-08d8e330c8c3
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 19:23:13.7228
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FiMt9QRVZ5yw4Qo55n4qcPlyb7k6GFfgxHHmO7YRFiFNY5Mho71Th3zYaLCzqzokMQ8oYW3vIOVnTdSsGsdDhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3046
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9918 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103090092
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9918 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0
 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103090092
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 9, 2021, at 1:23 PM, Olga Kornievskaia <olga.kornievskaia@gmail.co=
m> wrote:
>=20
> If the server's attempts at sending a callback request fails either due
> to connection or authentication issues, the server needs to set
> NFS4ERR_CB_PATH_DOWN in response to RENEW so that client can recover.
>=20
> Suggested-by: Bruce Fields <bfields@redhat.com>
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
> fs/nfsd/nfs4callback.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index 052be5bf9ef5..f436d2ca5223 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -1186,11 +1186,8 @@ static void nfsd4_cb_done(struct rpc_task *task, v=
oid *calldata)
> 		rpc_restart_call_prepare(task);
> 		return;
> 	case 1:
> -		switch (task->tk_status) {
> -		case -EIO:
> -		case -ETIMEDOUT:
> +		if (task->tk_status)

Can task->tk_status ever be positive here? Wondering if we want
a more explicit check like: (task->tk_status < 0)


> 			nfsd4_mark_cb_down(clp, task->tk_status);
> -		}
> 		break;
> 	default:
> 		BUG();
> --=20
> 2.27.0
>=20

--
Chuck Lever