Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] nfsd: Demote UMH upcall init message from warning- to
 info-level
To:     "J . Bruce Fields" <bfields@fieldses.org>,
        Chuck Lever <chuck.lever@oracle.com>
Cc:     linux-nfs@vger.kernel.org
References: <20210312112840.49517-1-pmenzel@molgen.mpg.de>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <acd50b86-a200-34bf-5768-e5bb93b2278f@molgen.mpg.de>
Date:   Fri, 12 Mar 2021 12:33:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210312112840.49517-1-pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Linux folks,


Am 12.03.21 um 12:28 schrieb Paul Menzel:
> By default, using `printk()`, Linux logs messages with level warning,
> which leaves the user seeing
> 
>      NFSD: Using UMH upcall client tracking operations.
> 
> what to do about it. Reading `nfsd4_umh_cltrack_init()`, the message is
> actually logged on success, so nothing needs to be done, and the info
> level should be used.
> 
> Cc: linux-nfs@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   fs/nfsd/nfs4recover.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 891395c6c7d3..db66c45a6b97 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -1864,7 +1864,7 @@ nfsd4_umh_cltrack_init(struct net *net)
>   	ret = nfsd4_umh_cltrack_upcall("init", NULL, grace_start, NULL);
>   	kfree(grace_start);
>   	if (!ret)
> -		printk("NFSD: Using UMH upcall client tracking operations.\n");
> +		pr_info("NFSD: Using UMH upcall client tracking operations.\n");
>   	return ret;
>   }

A debug-level message could also be used, or the line totally removed, 
and the condition be changed to print an error in case of failure. I am 
wondering about the benefit for the user reading through the logs. Maybe 
the log was only there, because UMH upcall client tracking operations 
were something new?


Kind regards,

Paul