Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 12 Mar 2021 10:32:57 -0500
From:   "J . Bruce Fields" <bfields@fieldses.org>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Demote UMH upcall init message from warning- to
 info-level
Message-ID: <20210312153257.GC24008@fieldses.org>
References: <20210312112840.49517-1-pmenzel@molgen.mpg.de>
 <acd50b86-a200-34bf-5768-e5bb93b2278f@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <acd50b86-a200-34bf-5768-e5bb93b2278f@molgen.mpg.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Fri, Mar 12, 2021 at 12:33:00PM +0100, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> Am 12.03.21 um 12:28 schrieb Paul Menzel:
> >By default, using `printk()`, Linux logs messages with level warning,
> >which leaves the user seeing
> >
> >     NFSD: Using UMH upcall client tracking operations.
> >
> >what to do about it. Reading `nfsd4_umh_cltrack_init()`, the message is
> >actually logged on success, so nothing needs to be done, and the info
> >level should be used.
> >
> >Cc: linux-nfs@vger.kernel.org
> >Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >---
> >  fs/nfsd/nfs4recover.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> >index 891395c6c7d3..db66c45a6b97 100644
> >--- a/fs/nfsd/nfs4recover.c
> >+++ b/fs/nfsd/nfs4recover.c
> >@@ -1864,7 +1864,7 @@ nfsd4_umh_cltrack_init(struct net *net)
> >  	ret = nfsd4_umh_cltrack_upcall("init", NULL, grace_start, NULL);
> >  	kfree(grace_start);
> >  	if (!ret)
> >-		printk("NFSD: Using UMH upcall client tracking operations.\n");
> >+		pr_info("NFSD: Using UMH upcall client tracking operations.\n");
> >  	return ret;
> >  }
> 
> A debug-level message could also be used, or the line totally
> removed, and the condition be changed to print an error in case of
> failure. I am wondering about the benefit for the user reading
> through the logs. Maybe the log was only there, because UMH upcall
> client tracking operations were something new?

Could be.

I think debug-level would be fine.

--b.