Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3] nfsd: Log error on UMH upcall init failure and debug
 message on success
Thread-Topic: [PATCH v3] nfsd: Log error on UMH upcall init failure and debug
 message on success
Thread-Index: AQHXF2K+y8nL9p7cMUSkigZChQyYHaqAtNuA
Date:   Fri, 12 Mar 2021 18:59:24 +0000
Message-ID: <D3838AAC-6AE6-40C8-B13C-AB19796BE36E@oracle.com>
References: <20210312170604.56169-1-pmenzel@molgen.mpg.de>
 <20210312170943.57461-1-pmenzel@molgen.mpg.de>
In-Reply-To: <20210312170943.57461-1-pmenzel@molgen.mpg.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FAF435C2124B284C95E3B15A7FA8505D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5ac544-5181-4bd9-af54-08d8e588f3fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 18:59:24.3938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yIDcGMkCZTAA1CI99Isj4imc8omrTFkatmYCu4GlcfzrXV3wTvDpd1BtiorbKI0KqNae3AlChITE5DEG46evkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3045
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9921 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 bulkscore=0
 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103120144
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9921 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 clxscore=1011 phishscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501
 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103120144
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Paul-

> On Mar 12, 2021, at 12:09 PM, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>=20
> By default, using `printk()`, Linux logs messages with level warning,
> which leaves the user reading
>=20
>    NFSD: Using UMH upcall client tracking operations.
>=20
> wondering what to do about it. Reading `nfsd4_umh_cltrack_init()`, the
> message is actually logged on success, so nothing needs to be done, and
> it was decided to use the debug level.
>=20
> Additionally, Linux now logs an error on init failure.
>=20
>    NFSD: Failed to init UMH upcall client tracking operations.
>=20
> Cc: linux-nfs@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> v2: Log error and demote success message to debug-level (forgot `-a` in `=
git commit --amend`)
> v3: Actually sent correct diff
>=20
> fs/nfsd/nfs4recover.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 891395c6c7d3..fff89c739033 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -1863,8 +1863,11 @@ nfsd4_umh_cltrack_init(struct net *net)
>=20
> 	ret =3D nfsd4_umh_cltrack_upcall("init", NULL, grace_start, NULL);
> 	kfree(grace_start);
> -	if (!ret)
> -		printk("NFSD: Using UMH upcall client tracking operations.\n");
> +	if (ret)
> +		pr_debug("NFSD: Using UMH upcall client tracking operations.\n");

Looking back at 869216075b63 ("nfsd: re-order client tracking method select=
ion"),
the idea here seems to be that only one of the "Using yada upcall client" i=
s
supposed to fire. If an error occurs here, there is a fallback. No addition=
al
error need be reported, IMHO.

So the printk() call-sites added by 869216075b63 all need to be adjusted to=
 use
pr_info(), I think?


> +	else
> +		pr_err("NFSD: Failed to init UMH upcall client tracking operations.");
> +
> 	return ret;
> }
>=20
> --=20
> 2.30.2
>=20

--
Chuck Lever