Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3630579pxf; Mon, 15 Mar 2021 14:22:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2ExtaRD7OD982wdJupgFm4YMAxc6aqqxI8j4S0QcIoAGtNXzBWaa76gFE8fjRVfex5UM/ X-Received: by 2002:a17:907:76bb:: with SMTP id jw27mr25754371ejc.366.1615843321649; Mon, 15 Mar 2021 14:22:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615843321; cv=none; d=google.com; s=arc-20160816; b=q6lr3hYwqgIsaFfgNnA2HGs/aZMyWgOx1dzLwrdLf963eXMiIcSN2zvVDmxVfqfn+R 7nfLJlJpOF326dEfij/5wBdtq/LFlpexwIIA3ufNuF+F4dsf1mL1EbRrDqWlARse94uw 7kLsN81BCDk6FRGVNKn+Yq3hDXJzaKGHufnNUEyqSrvG1mWgMtQFXKSfihKAyMdITrhZ /1+ehl58WEGoOsE8vb4ai1WLWQZTvZAdS4RFc3UQGlNYvcmFjdHjYoyZQdD3nAQ73Cw3 iJ5V4lAqPEitT9+tvhxcVxObOgw7lyIxkDWqK7gBYiMV1ICWvZGu2fdR0oE24qmIzsCS +UYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=RFIjDQlgAbDZb84hCcz/nIlskkxfDKDLDVdmAvsZ6QA=; b=HE/ppmwhIrsgGez13UqjjgXHbxo/4W7K1yZs4xzQhaJQn4GpzAdQll6wdapZ2bB588 waaqF+DtPOJAvLxcouxjl+ae1cVXW/HHrl2kDjPrGbcRCyXsRKmq1LSN86FIiBH3v1S3 Kw26LQKo4MvhRnloDCvjQH+kfGousI76vF/PtjfGTS0EVpBiruEpRbPnlfGF+l+EIRn8 wOKgxZM81rcAiJbzCX7uLytxElgs7ZmFO/pmKJ3qIrqEoaF6dNrbXZ+4yw4cSD+eCoak PAcyOwp1Nco5L4pnTmZQZAv7AxHdjjR7Ky3U8HP58z4ekV9P0lE73X7EAPUnfv/N/JZ7 FtBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+SC14pf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr12si12127670ejb.306.2021.03.15.14.21.39; Mon, 15 Mar 2021 14:22:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+SC14pf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbhCOTdp (ORCPT + 99 others); Mon, 15 Mar 2021 15:33:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59012 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232773AbhCOTde (ORCPT ); Mon, 15 Mar 2021 15:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615836813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RFIjDQlgAbDZb84hCcz/nIlskkxfDKDLDVdmAvsZ6QA=; b=a+SC14pf8METtE5z7CEnSeVPnHPeXq6P6HgB8jUCthVZahqCNDXD4i6vXttgaxvZojmJYZ IMEOaKxf1kfVO0t7oL/Bvs81ds9/HDVxbovKzNf/CU+m7gzy8hA5T8OkszCS6lMhbRQ7/F PxqEDzEY9VS4D5YS8OplNrPOaaNopsE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-2zLsoK69PWCE-vaq_Q0KEw-1; Mon, 15 Mar 2021 15:33:31 -0400 X-MC-Unique: 2zLsoK69PWCE-vaq_Q0KEw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42B7B100C618; Mon, 15 Mar 2021 19:33:29 +0000 (UTC) Received: from firesoul.localdomain (unknown [10.40.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1FE210023AB; Mon, 15 Mar 2021 19:33:25 +0000 (UTC) Received: from [10.1.1.1] (localhost [IPv6:::1]) by firesoul.localdomain (Postfix) with ESMTP id 524D93250E696; Mon, 15 Mar 2021 20:33:24 +0100 (CET) Subject: [PATCH mel-git] Followup: Update [PATCH 7/7] in Mel's series From: Jesper Dangaard Brouer To: Mel Gorman , linux-mm@kvack.org Cc: Jesper Dangaard Brouer , chuck.lever@oracle.com, Alexander Duyck , netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 15 Mar 2021 20:33:24 +0100 Message-ID: <161583677541.3715498.6118778324185171839.stgit@firesoul> In-Reply-To: <20210315094038.22d6d79a@carbon> References: <20210315094038.22d6d79a@carbon> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This patch is against Mel's git-tree: git://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git Using branch: mm-bulk-rebase-v4r2 but replacing the last patch related to the page_pool using __alloc_pages_bulk(). https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git/log/?h=mm-bulk-rebase-v4r2 While implementing suggestions by Alexander Duyck, I realised that I could simplify the code further, and simply take the last page from the pool->alloc.cache given this avoids special casing the last page. I re-ran performance tests and the improvement have been reduced to 13% from 18% before, but I don't think the rewrite of the specific patch have anything to do with this. Notes on tests: https://github.com/xdp-project/xdp-project/blob/master/areas/mem/page_pool06_alloc_pages_bulk.org#test-on-mel-git-tree --- Jesper Dangaard Brouer (1): net: page_pool: use alloc_pages_bulk in refill code path net/core/page_pool.c | 73 ++++++++++++++++++++++++++++++++------------------ 1 file changed, 47 insertions(+), 26 deletions(-) --