Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp983794pxf; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwUsvD2l86r+5yJvlVnWUpTT4uXR9DnYmxRoFCX4uQr7DbJe4mA6GVBF1w5dvFBf/VHbvO X-Received: by 2002:a17:906:4f8a:: with SMTP id o10mr1309875eju.484.1616112311199; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616112311; cv=none; d=google.com; s=arc-20160816; b=s8AegcQYlXJyuIwxtoySL5syHHWRvT0S9S7Sr7a+XqDkkZBzRXAj6zYWBzz/xoc9rH uNH7njZ/LDWAyMcUXVOUwlfkKEJh0AaM4TnUf8u67p6rzucp3EYNyyJsCpDFsw/VKeME +VSQjignGHkdfeEiMAue6zEECfEQ10hGcYDivwouM+ktlnaetHMFdTSTYXToZr/8ognH k5fcAwOVLs4Utpy0QGJ/vB8odM5f41L/6f/xNm9FjIXxz3oy6tOc+wV4tckrBanAwSu3 /huPDHcNK5ceJD6vGYCE9UoyV8mBNZ/UIrurk1IjfmKPB7Fm4GOAZzTaHo7c0mzMumMq Md/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dkim-filter; bh=Ne41XQzGrhR/kIqA5jpybLIiseSUu5jnqK1HmqS3NFc=; b=Pk4xNWAs5ejCKXBcstk7GiCoAM2sVt60CdpqntHbMpiys5z/EY/0+POo9OwrJgh9gy 7ZjqatSnNarrmQEGGggLYJ0S9Cssl5kcRtatS/b8nDI8uenhklIDAFsRYJvoJRl0RMXm Zy3qdxnEaRa/O/jAHmfpXW5atvjkJoz3qItd0l0O8ShEW3EJe2EhyBpPZId2hXEikfMm CTW/LPage6Q6wyZe68hIDtJ7ClVfrDDXZVLEWIlESUgYyBu6oBEPzr7SVSMKDuae7BvG vAOa327oIhMrrhIQnl3qykNZGKJssBIqLxDSqyx3+BT7ZgyWUpkxioiLCOGBIztV2kNe S2tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i25si2953532ejv.640.2021.03.18.17.04.33; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhCSAEC (ORCPT + 99 others); Thu, 18 Mar 2021 20:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230478AbhCSAD2 (ORCPT ); Thu, 18 Mar 2021 20:03:28 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51059C06174A for ; Thu, 18 Mar 2021 17:03:27 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 063AC1F78; Thu, 18 Mar 2021 20:03:25 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 063AC1F78 From: "J. Bruce Fields" To: Chuck Lever Cc: linux-nfs@vger.kernel.org, "J. Bruce Fields" Subject: [PATCH 1/2] nfsd: don't ignore high bits of copy count Date: Thu, 18 Mar 2021 20:03:22 -0400 Message-Id: <1616112203-14672-1-git-send-email-bfields@redhat.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: "J. Bruce Fields" Note size_t is 32-bit on a 32-bit architecture, but cp_count is defined by the protocol to be 64 bit, so we could be turning a large copy into a 0-length copy here. Reported-by: Signed-off-by: J. Bruce Fields --- fs/nfsd/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index b749033e467f..5419342df360 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1383,7 +1383,7 @@ static void nfsd4_init_copy_res(struct nfsd4_copy *copy, bool sync) static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy) { ssize_t bytes_copied = 0; - size_t bytes_total = copy->cp_count; + u64 bytes_total = copy->cp_count; u64 src_pos = copy->cp_src_pos; u64 dst_pos = copy->cp_dst_pos; -- 2.30.2