Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp983795pxf; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxATztUnOUYIEgWbT0NlduEj5qWTTq3CT4H9Gd63WcU86kcjRZQN1y749TpzraIYLRLtmdc X-Received: by 2002:a17:907:3ea0:: with SMTP id hs32mr1224031ejc.411.1616112311203; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616112311; cv=none; d=google.com; s=arc-20160816; b=FS1r8ryvg8FAq5ts0cvauH3kH50q+m9+ULphC+cQyQylzrIJj5omh6nUdqLqbustco AmZ16bD6uZoVXfCgdUhoYB/fbS9kLuR+N3o1pHMkHYfJKX5oCtl9QEFx1tWh75v28cHa nIRSBks4y0vI0R5PUf+60comvNqWdvBtUqNLbx/8yduaq+G4JzOylIo+FMJalUy2c/0F 39Se/FDCE8Wr6AEPcaxoN2VwJv4zlz3EKw6DLcqVfaW74jtKcYzwSBgQoEAzzFZvn0Jc vqgpRHBChaHKcp/FrgD27ObMGNc1WiqqrXJrRsdnSFWtRd6ElQe1rm7dGf8b+L67siE4 6Unw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-filter; bh=f+ZV4IUgyJBmU6oj3snFEwCJwrs5KPppbG7gCKrKgmE=; b=y15KYsAwb5Bt3jmoMG3GzZjmeRGRNqiMxnhkzohfrreAwLaNxzeti1Q1LgtYziBZBQ LhUnSVgucXxRzVSTorvyaDlTAr1U+29EULLPfMIQROTIQC63QJ2Z83FaqJM9sLd9ZpFL 7mEBGohlRqTp3bao43113MsZ67fiptp6Vf9yUja4Vsfv+nuH2ulhdfqTZlTGWFpF7CRt khe8PMPpGBy3WoHXHq4/rToLUPXhRi3PqSYfXOgmAlQ++FY7405BKORzYt/r+/kdPzJk ViLpFnmlNEPMklW+6dglgMQkn3zNKrnG7/8yDmX2grFkuvFRYZPUPC/MUsp+U/MUIIb+ o2wQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si2725634edp.540.2021.03.18.17.04.36; Thu, 18 Mar 2021 17:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbhCSAEB (ORCPT + 99 others); Thu, 18 Mar 2021 20:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCSAD2 (ORCPT ); Thu, 18 Mar 2021 20:03:28 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917F0C06175F for ; Thu, 18 Mar 2021 17:03:27 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 10A29A6F; Thu, 18 Mar 2021 20:03:25 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 10A29A6F From: "J. Bruce Fields" To: Chuck Lever Cc: linux-nfs@vger.kernel.org, "J. Bruce Fields" Subject: [PATCH 2/2] nfsd: COPY with length 0 should copy to end of file Date: Thu, 18 Mar 2021 20:03:23 -0400 Message-Id: <1616112203-14672-2-git-send-email-bfields@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1616112203-14672-1-git-send-email-bfields@redhat.com> References: <1616112203-14672-1-git-send-email-bfields@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: "J. Bruce Fields" From https://tools.ietf.org/html/rfc7862#page-65 A count of 0 (zero) requests that all bytes from ca_src_offset through EOF be copied to the destination. Reported-by: Signed-off-by: J. Bruce Fields --- fs/nfsd/nfs4proc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 5419342df360..62354229f0b0 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1387,6 +1387,9 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy) u64 src_pos = copy->cp_src_pos; u64 dst_pos = copy->cp_dst_pos; + /* See RFC 7862 p.67: */ + if (bytes_total == 0) + bytes_total = ULLONG_MAX; do { if (kthread_should_stop()) break; -- 2.30.2