Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1479967pxf; Fri, 19 Mar 2021 08:03:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg2pU5FIjTArU85W3+elppEDQUDyz1Cnj6cueCrHp452Ni93umBEeLA+ggDANTGu65W5Q2 X-Received: by 2002:a05:6402:c8:: with SMTP id i8mr10179117edu.57.1616166225459; Fri, 19 Mar 2021 08:03:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616166225; cv=none; d=google.com; s=arc-20160816; b=X5Qnttk/IK8KUvwURokqDSyow+w4iHEakeYRx0UXP66Vct0AmNu2llSdBcWWzSALye i2ZbSwoDFPnSLi4QvPlF4wMlM+WUsOSyJ7hNbDRLYQa47idYs1zUm+5E5jW3QcRp3/5d vhwOUC0xXtB7lmGp5gr+082RSTOGBjAs34IKlcnpWymG9D7eNcUx21MzBwFmSGZ5k8M3 PClqvwVGlw2OxmuAGG5uabvmjyVQwXQf3MF+jFfLx4z8IdV8k5ViztLb5qDKW4PXrYbn XNSNHUL0dhoKx3LHtnj28cAZpmDJSdXx1sgJvhhN9zJtReskYtuE0cbHUh1E8qtxOOEW 38oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vUoOu7agSTM4o48gPJLYLcyZ5QlQnr4TzAJ4RXshIiA=; b=kBfQnytHFFaOaM53gyPO3YwwtkQl5CEdoAIsyKSaYCdeip3U/06n9TF1g9+rkBaHF0 hGHBmMTaM0RkFTQDN01CB/jaiE5gR2hxS2MMPpqosAxa3QnfbLnxTD2HD2KrERkXlTW6 hpydrPtByhYy2TQukzRFD7kolXNkvb4GYnHrPOaerR81OceeMhqDWr1XPF7jbFLRZwO3 5BEgrmuo6Xy4zv67ji2frk8YOxZKI/c2XMNV7i8FlU9ljJUOAuWzV4gx1LvQ3A9NERIu o2PtefuuWUCyqt4yDhnthCT5AHZL0H5suF5bxcIXZWtuW9p+u6rEyc3rJnGBdk1Soq5R LP4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=JinUrHEY; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si4371656ejg.105.2021.03.19.08.03.21; Fri, 19 Mar 2021 08:03:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=JinUrHEY; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231146AbhCSPCt (ORCPT + 99 others); Fri, 19 Mar 2021 11:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231139AbhCSPCj (ORCPT ); Fri, 19 Mar 2021 11:02:39 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C53C06174A for ; Fri, 19 Mar 2021 08:02:38 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id b7so10243868ejv.1 for ; Fri, 19 Mar 2021 08:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vUoOu7agSTM4o48gPJLYLcyZ5QlQnr4TzAJ4RXshIiA=; b=JinUrHEY3FUG3OBWYgdkbr0nNigXWVhQbYi/zz2Lyw2IQscLLz+ylaA59Vz2ZQIaj2 XFWDWbhnWISuQXmnhJ37LtdkNW00EcCi7y6vq1DmMb9OsXX+aEjgyJpHFwqTHeVXhOl2 uK+Qa21XBNANTUm/wEPUOZga/pcdojyhH1bTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vUoOu7agSTM4o48gPJLYLcyZ5QlQnr4TzAJ4RXshIiA=; b=TghQOS0m8Vnlr8ortdwBADlVBeOOEMZ07ga8hezqRYPlDGRR5mkjmYRlKYb9CNCpQU eJW4lZx13dZsCuG5DZHWgLZXIF23Gqm5juUQf2tQNVFZ0vd9CiWszSs6316RT4Wlt5xB QcVGliAQFauup+a00uf7xWwr1kZJwkNjx5nnE05oDI8kfkrMR0ynrFec0hqB9gMw1S7B cuib9NO1TK1okaftjq1OxHGnO62xBTUKf5utq3SfNcGfuAWddyD6z0+xki7CbVVlhH0I HbjTj2F6aJlPvELNT40vyS6Q4+krpWFikR8EVjpvxzdJHsk2/y5RMavwFviPx6cEtNmR fSXg== X-Gm-Message-State: AOAM531N2ag+JU4QeKTClzaws8PkcUAjoEPpf+TvJArJBD2TQEr6oFRE 7nFaEUhEVo9hhnXErR63gY4aQdc9CyjPWk/R X-Received: by 2002:a17:906:7f01:: with SMTP id d1mr4992321ejr.136.1616166155402; Fri, 19 Mar 2021 08:02:35 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:fa59:71ff:fe7e:8d21]) by smtp.gmail.com with ESMTPSA id sb4sm3858358ejb.71.2021.03.19.08.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 08:02:35 -0700 (PDT) Date: Fri, 19 Mar 2021 15:02:34 +0000 From: Chris Down To: linux-nfs@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chuck Lever , "J. Bruce Fields" , Trond Myklebust , "David S. Miller" Subject: Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hey folks, Let me know if you'd like more evidence that this is a persisting problem. Also more than happy to change the generation of the whole debug string to go into svc_sock_reclen_ascii or use LOG_CONT if you'd prefer to avoid the multiple ternaries (but the latter probably needs some thought about how it interacts with ratelimit). Thanks, Chris