Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@redhat.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] nfsd: COPY with length 0 should copy to end of file
Thread-Topic: [PATCH 2/2] nfsd: COPY with length 0 should copy to end of file
Thread-Index: AQHXHFNU830eg5Y6X0WV8w4eduDkKKqQFSUA
Date:   Mon, 22 Mar 2021 14:23:17 +0000
Message-ID: <A06DEECA-E34A-4E9C-B7E1-8ABBED01545D@oracle.com>
References: <1616112203-14672-1-git-send-email-bfields@redhat.com>
 <1616112203-14672-2-git-send-email-bfields@redhat.com>
In-Reply-To: <1616112203-14672-2-git-send-email-bfields@redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8F9358E3476C0548A9B822C70140B760@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fe4be49-1ceb-4abf-0bae-08d8ed3e0939
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 14:23:17.0318
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ngp1/LF5589OLjXY/zZXJl6DwqXQ01JBU52TVXAGPkGysOoeYHPrsQeAGngXPioEzGxGt2ZcOwCx6WSm6c4pQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3048
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103220105
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 phishscore=0
 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0
 adultscore=0 clxscore=1015 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103220105
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 18, 2021, at 8:03 PM, J. Bruce Fields <bfields@redhat.com> wrote:
>=20
> From: "J. Bruce Fields" <bfields@redhat.com>
>=20
> From https://tools.ietf.org/html/rfc7862#page-65
>=20
> 	A count of 0 (zero) requests that all bytes from ca_src_offset
> 	through EOF be copied to the destination.
>=20
> Reported-by: <radchenkoy@gmail.com>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Hi Bruce -

These two have been committed to the for-next topic branch at

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


> ---
> fs/nfsd/nfs4proc.c | 3 +++
> 1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 5419342df360..62354229f0b0 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1387,6 +1387,9 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_c=
opy *copy)
> 	u64 src_pos =3D copy->cp_src_pos;
> 	u64 dst_pos =3D copy->cp_dst_pos;
>=20
> +	/* See RFC 7862 p.67: */
> +	if (bytes_total =3D=3D 0)
> +		bytes_total =3D ULLONG_MAX;
> 	do {
> 		if (kthread_should_stop())
> 			break;
> --=20
> 2.30.2
>=20

--
Chuck Lever