Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp425376pxf; Thu, 25 Mar 2021 07:13:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIhLE5lXOiFyOsELFa823gD5GGfeWgXyy8JGeI34XqAfUlhL723Kafn1tJ7YoM9C0BHbNO X-Received: by 2002:a05:6402:30b9:: with SMTP id df25mr9588228edb.136.1616681619320; Thu, 25 Mar 2021 07:13:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616681619; cv=none; d=google.com; s=arc-20160816; b=rS588OgoNl7Z1E2f6HI/GWxtCrmNUZMyKoHIiu0/zTPLpQ+3TARbDLO4I6AaeFftc0 HMq0Mu1txhRd5omNWSOQUMsdwPTMyjC5xL8WIlcTD0V947FhObr2vzdtbY98pMgbx0vv 9DWg/FAgu2TxRyP65V4KKm525Rr6woIVqTE9tVyMMguRbqma99wlefeNI+3ZwzfZSdUC slIYn34MCD9k/uaIMi7068O822tdbsePsiVm8dpjqdI3Zkf08DURiHbjgM5MFLHnq3CK qsxESMfpvh6oG21yhPZ3T4kTzIBSMnkVs63JCsOkhdoOsBlAF/9C63wQCzUF4JipLoMc Sq7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JP8HgLro6AbZLt2MNRw3IANQzsJHTI7f+9qGAMl8N+o=; b=qYYzhAunG2xyK8aP0EwlnoqT3rRrdJm1uarOOM4Nn00XQD/v2APWEpUT9YS+Yh2NDe kzBPRw8f14/ckXqy9KPrdaBCuHqEKk5I9bekFWf1U4N71cG9hZxxbgAki2jKX+wwOX6y lM23neb5xlThxKnxtxSVbq+hwlYBgMO41EVu//v3XVBcJfZ95Nu6V/3zssXWYkUA1Req KoAqgI28cAQMvSmYPA/p7ZqVaO4noRMvTO6uN+ASwD8wyLqYV/THmSObkHjjAiZWOfIm FtXxYzgPFOnjBtecKIxB7VM636xc1xZtbMLRARoNMD/jtC4ZCfH+jq3j2s48wOACHjvU TvDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DqxCWL1J; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si4335863ejw.277.2021.03.25.07.13.13; Thu, 25 Mar 2021 07:13:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DqxCWL1J; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbhCYOLS (ORCPT + 99 others); Thu, 25 Mar 2021 10:11:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231363AbhCYOLH (ORCPT ); Thu, 25 Mar 2021 10:11:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE444C06174A; Thu, 25 Mar 2021 07:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JP8HgLro6AbZLt2MNRw3IANQzsJHTI7f+9qGAMl8N+o=; b=DqxCWL1Jwo4lXLuI8106Mtc5CH xO+DdWDRM0Td8F33WQ76z6ScIV5K9cYesdzhidA/U59KlheKVM9ru2K4rQw+FnZkihJjyMCJWDrOB qoTYDqRIOc8GtvXzO7LrF3nxl7VwtYxe9RD0c91IGwws8nuVnV495Fsx1nuJK1jtbgWJHMI5raAKA vcAi/HluSaIZCxyhhvx9VlaqFcsrhsys7PvvJTLqBH8C4wVDp7quMAkJsNG3heDRjBQ2L8GmrV48a O994D1ERIF8PdGJwzN2cAFG6T8e9DjIxlVUAu62LmDxaGMO+iWxXfEG1g89MlJUqZu5sAmczL519w rZzBKMtg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lPQfv-00D2MO-Bh; Thu, 25 Mar 2021 14:09:33 +0000 Date: Thu, 25 Mar 2021 14:09:27 +0000 From: Matthew Wilcox To: Uladzislau Rezki Cc: Mel Gorman , Andrew Morton , Chuck Lever , Jesper Dangaard Brouer , Christoph Hellwig , Alexander Duyck , Vlastimil Babka , Ilias Apalodimas , LKML , Linux-Net , Linux-MM , Linux-NFS Subject: Re: [PATCH 0/9 v6] Introduce a bulk order-0 page allocator with two in-tree users Message-ID: <20210325140927.GX1719932@casper.infradead.org> References: <20210325114228.27719-1-mgorman@techsingularity.net> <20210325125001.GW1719932@casper.infradead.org> <20210325132556.GS3697@techsingularity.net> <20210325140657.GA1908@pc638.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325140657.GA1908@pc638.lan> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Mar 25, 2021 at 03:06:57PM +0100, Uladzislau Rezki wrote: > For the vmalloc we should be able to allocating on a specific NUMA node, > at least the current interface takes it into account. As far as i see > the current interface allocate on a current node: > > static inline unsigned long > alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct page **page_array) > { > return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, NULL, page_array); > } > > Or am i missing something? You can call __alloc_pages_bulk() directly; there's no need to indirect through alloc_pages_bulk_array().