Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3973777pxf; Mon, 29 Mar 2021 17:20:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEODyoJyvAcPEKqH50Pg/tucse68GBujLNbiDAFLcK2XggGShm53aaV3Ioe2SfwVLVJuH2 X-Received: by 2002:a17:906:2b0a:: with SMTP id a10mr30962134ejg.513.1617063619562; Mon, 29 Mar 2021 17:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617063619; cv=none; d=google.com; s=arc-20160816; b=wII6yDtT7+d0otjD4O1kMKr8sVuuWVAxToZwU4n0mG1hQnyXtNBEo2WEdn+97KjSH7 fA/x6KwEx+xwDhnJMHrdrIYaA3+MJg/iaKmEn2Is/mV1Sw0XsSNlC5P1IwuPoI28hBbQ arhlNU/gBXzm7mnpyM1C/Xdk7epoX89UfV7mytYVFsafFV9c+sH2olgBnlWbCNsHuTPW gyuTDlLay4C4wgrHbEWpmKrSd3jEZeiAdLaQeta36nXLowcGM/eTAZClKWHnTCQcaHGL 4W6mLtez/er49XsUEGmy6NYk8aUp4ne9eiqxe5ld04w4F2gRmDFOzNBfUGeQcARvm2OY xXgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=zkdPoBWS1aXzN+z5W+H38f5ehJ3iQlyxgMwY/beGATI=; b=R5CqVPrL7LgDbNsBO6lH+KcCBGsDTa6EJ6QvAP25CBeeogetgN4rgn0Yk5x3Li5yEP SaMRh42cfTXdyIldEJrn0PxVKMz18qOMVb6xtW6cWjkfO+tWL4qPULbsKVkpx9odZDvC QdESdvz0z83/CaDTEa1ueOJB/IFqLe+zhRKocm6UImvSczDumAwXX4FtGsYLfBBnYi4x 2cMOt2YxegvB7HNukLtsTFr7GXP+xmNqf8fRsJ/KjlKTk9GOhJ0WxCGpW2tx1f1mb8ne SzGjnq9sobUZiy3uGSI920QVTY6Lq2BtJlvPtkleZa6E2wiNkbH2xDOKTevkkW0Meb9T q1Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H2N8Pnow; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si14028570ejx.42.2021.03.29.17.19.50; Mon, 29 Mar 2021 17:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H2N8Pnow; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229441AbhC3ATL (ORCPT + 99 others); Mon, 29 Mar 2021 20:19:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:50362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbhC3ASk (ORCPT ); Mon, 29 Mar 2021 20:18:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5AE7F61990 for ; Tue, 30 Mar 2021 00:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617063520; bh=uXmtav0HD1YHoLdGD1OavpObIiaLKCCy08ovhHhtnaY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=H2N8PnowH+GYZEwjyU2YZyjTbvb6s1wXQvxpwV/cW0sVNNsVJHLGUKgJp623DqzDy jl+rQzil+e8E3Jt2iNtAo3m2Bb/sN/54/N00AVwTnMnK4HK5HV/BrwacFOYHHSTOix wuH8M4LttdCyI0SmKs0cfnWdqZdHX4vElGAlvgu5vD+6eZrU0/m5hcP7fLL9/3YlM5 LqfExp+q7ZIPRHcvpoy6sLDGygp40Mu5ybsf74XM5aMKGTC3FWlmoiiedmaPHRQ8yH yuK7QCu7A65zgtorGX2WjiWybMJi7WCyTf2LlRwGkO77x+ODVgAl3cstl9ZWVcG8Ys 4BLZHN16JIc6A== From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH 04/17] NFS: NFS_INO_REVAL_PAGECACHE should mark the change attribute invalid Date: Mon, 29 Mar 2021 20:18:22 -0400 Message-Id: <20210330001835.41914-5-trondmy@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210330001835.41914-4-trondmy@kernel.org> References: <20210330001835.41914-1-trondmy@kernel.org> <20210330001835.41914-2-trondmy@kernel.org> <20210330001835.41914-3-trondmy@kernel.org> <20210330001835.41914-4-trondmy@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust When we're looking to revalidate the page cache, we should just ensure that we mark the change attribute invalid. Signed-off-by: Trond Myklebust --- fs/nfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 93f487c15663..f0c983151f3c 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -219,7 +219,8 @@ void nfs_set_cache_invalid(struct inode *inode, unsigned long flags) | NFS_INO_INVALID_SIZE | NFS_INO_REVAL_PAGECACHE | NFS_INO_INVALID_XATTR); - } + } else if (flags & NFS_INO_REVAL_PAGECACHE) + flags |= NFS_INO_INVALID_CHANGE | NFS_INO_INVALID_SIZE; if (!nfs_has_xattr_cache(nfsi)) flags &= ~NFS_INO_INVALID_XATTR; -- 2.30.2