Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kael_w@yeah.net" <kael_w@yeah.net>
Subject: Re: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
Thread-Topic: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
Thread-Index: AQHXJt1tLMsicTn0z0C3EtS8D4Tr3aqfqUUA
Date:   Thu, 1 Apr 2021 13:32:47 +0000
Message-ID: <82C3737A-E6CA-469E-B159-85DBE3657221@oracle.com>
References: <20210401095658.1006341-1-wanjiabing@vivo.com>
In-Reply-To: <20210401095658.1006341-1-wanjiabing@vivo.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D9D94FABC7700542AF3FBE31696FF086@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ff4671ff-2d5a-4c13-6f6b-08d8f512a38d
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 13:32:47.4439
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LRZEB9HQpSQuaX89+3mvywQmFW8cseWV4npZBviWT5/joqx3m/3Tk8HEppHi3ORlTZhz67RSLxMCWh1tzCTGWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2757
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9941 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 spamscore=0
 mlxscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103310000
 definitions=main-2104010093
X-Proofpoint-GUID: C2VwmGDcXK9Qh-1l3lCnxQwRqX3XqeVr
X-Proofpoint-ORIG-GUID: C2VwmGDcXK9Qh-1l3lCnxQwRqX3XqeVr
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9941 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 adultscore=0
 clxscore=1011 mlxlogscore=999 phishscore=0 bulkscore=0 priorityscore=1501
 spamscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103310000
 definitions=main-2104010093
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi -

> On Apr 1, 2021, at 5:56 AM, Wan Jiabing <wanjiabing@vivo.com> wrote:
>=20
> struct rpcrdma_req is declared twice. One is declared at 216th line.
> The blew one is not needed. Remove the duplicate.

s/blew/below/

>=20
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

Thanks! This one goes to Anna.


> ---
> net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_r=
dma.h
> index fe3be985e239..11e5fbfc642c 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -239,7 +239,6 @@ struct rpcrdma_frwr {
> 	};
> };
>=20
> -struct rpcrdma_req;
> struct rpcrdma_mr {
> 	struct list_head	mr_list;
> 	struct rpcrdma_req	*mr_req;
> --=20
> 2.25.1
>=20

--
Chuck Lever