Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp918046pxf; Wed, 7 Apr 2021 15:02:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjq9edLl90BnYYtsaunNiRfbcsu4QzmlV59z8452uBuwIkaA7xWTXSIb01imGadlI1oieU X-Received: by 2002:a17:902:ec87:b029:e9:8772:6668 with SMTP id x7-20020a170902ec87b02900e987726668mr994789plg.15.1617832970436; Wed, 07 Apr 2021 15:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617832970; cv=none; d=google.com; s=arc-20160816; b=MkR4G92kZQE/PprXWp25NjlWk+Up/zquoESP3B2ri5gqLvR8l5wmwuCUvEv8+Msve4 nJ6gpquCHc941mrQHXP/P4sIBBDAGT5B437MTap1n+u+WPE3/StDPuQ7lE6lnTPIB0Fw zqirm2+e8fBZwp6qp5NYBw3pXOp/sUTrHtnxMp5uIqHjZdQvxoRx/AYSji+Gc9u7X9cX U9SQrL6TTxZ5C+/LhFGdDSfVdc/XCfZuz2WitIGW/8vR/e7nbCmQ137s97fXcamLKl+1 Ucyjc21nIKq4h7fINnuHzfbnO+DadvcS7KePZY0JFxiRwNI2pn1U5U3NpMNDDBdmgZmv TL+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=8Up6+QzPmEICbzN15AwrZjkZw9JH60/A0HX1z5/TdI0=; b=I4jP/npGo9dTed5yPT42esJ98wKImLfIz4yh6ZmHoK74Iu4hQHkPyt3iTCZmf/EgSu rvs4w57t6RRUzHYTlPR0mVNhkpMSLvmUsCD6vgNxG34mTen15wAMo6Lq3h+V9GtJmbOv 82bJ+uTNhJRi3ToxHZCSHHLP6M9XjtpGVVWZNd6yWhPvurfbwXAUt7yIkT4MhHXHQS8I Ozt2OP9UO4NXERWpbD+XgFORlMsg8xVorcpQgqY8CNvf7RWMJYGGdRDGjz11Nhlf/tl3 jAGnh29i/LAI94F3HF2uqZUbfKllbwwM9Lt6xdXXFLF74azD0yjnVLymQu7u1V3Y56U7 2jbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jctupu8s; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si2383045plb.431.2021.04.07.15.02.36; Wed, 07 Apr 2021 15:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jctupu8s; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234428AbhDGUg1 (ORCPT + 99 others); Wed, 7 Apr 2021 16:36:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:60638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233158AbhDGUg1 (ORCPT ); Wed, 7 Apr 2021 16:36:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00ABE6108B; Wed, 7 Apr 2021 20:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617827776; bh=ugr+drc7bf7S8IBKqVOw+nPN9jCbdOI8SZ6o5VM7fwY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jctupu8ssSv9vuAXQCQ7FIycZ12H5N98RhHey567kgxlZMZTaHivBDFa8n8CUsPFA zylBOz7GSkLbEedxd2ePdSvte8QDLug3MTlzrJnV2yfEAzVILjqqo2MPyDRnKt/SCQ jya/dcYqvV2xAf7GFwsYNY3YDEHZUGJjJdyVetUwDbCdVTrFwU00wtngiHGw12yIOd i/ycYjSQgG7eqE4mx/2Z0z52nN/8w3nsNloKW0QrF31fJN2vYoflWCuL7Y02KGzzpW nmrFQMurfQuMK8szVsvSy24473mXID/KGHSThQXjDYS9fQh9MjnOUCZoODlhMvgIkJ FwMOl2d6fO0AQ== Message-ID: <0df4fd45c51dd8e87aa2a0869d81c39c9af83b31.camel@kernel.org> Subject: Re: [PATCH 0/5] netfs: Fixes for the netfs lib From: Jeff Layton To: David Howells Cc: dwysocha@redhat.com, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 Apr 2021 16:36:14 -0400 In-Reply-To: <161781041339.463527.18139104281901492882.stgit@warthog.procyon.org.uk> References: <161781041339.463527.18139104281901492882.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, 2021-04-07 at 16:46 +0100, David Howells wrote: > Hi Jeff, > > Here's a bunch of fixes plus a tracepoint for the netfs library. I'm going > to roll them into other patches, but I'm posting them here for separate > review. > > David > --- > David Howells (5): > netfs: Fix a missing rreq put in netfs_write_begin() > netfs: Call trace_netfs_read() after ->begin_cache_operation() > netfs: Don't record the copy termination error > netfs: Fix copy-to-cache amalgamation > netfs: Add a tracepoint to log failures that would be otherwise unseen > > > fs/cachefiles/io.c | 17 ++++++++++ > fs/netfs/read_helper.c | 58 +++++++++++++++++++--------------- > include/linux/netfs.h | 6 ++++ > include/trace/events/netfs.h | 60 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 116 insertions(+), 25 deletions(-) > > Thanks David, I rebased onto your branch and gave ceph a spin with fscache and it all worked fine. Let me know when you get those rolled into your branch and I'll rebase the ceph/testing branch on top of it. Cheers, -- Jeff Layton