Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1465993pxf; Fri, 9 Apr 2021 09:04:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC/gPJ0ae3L5PKKhBXvFfpEnWdl5PJe2UWmxFOWHrWYk5Tn5txeqpxxgzLD0ToGJnf7mDh X-Received: by 2002:a17:906:1444:: with SMTP id q4mr16762601ejc.343.1617984283273; Fri, 09 Apr 2021 09:04:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617984283; cv=none; d=google.com; s=arc-20160816; b=fzw5KS8UrsFWWpAbgFsMWEt7/+hdD9KP2t5GweR/7HXJWdJ9pSElKRGeOjbsJOON4y 7YTYZiIrh34wG/6aJ2TvkDnYpW6KeEJNPkrNgltMSPn4l0aIOHERUf8d5pnuvsKRr6k5 ETcVQ6I6Jl0nh6NM9y2lvGYzp/ENRCEzdqZL2lWZdUl/9UqXaVwxtkT3lY9uaV8XnAtM oYQPMWQ29CuNSXQepuTHWHqwLrBFS2kDuwpZrQOyz1k9aLkrnPxgV8jFjKe766x5Vmna 2fYOgmwdab1ac/7xr7yxXh2w3wu5MR1zqxigKVe5iQx5vHcMi0zk+mCV0udISCsjtI1V 5bNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:message-id:date:content-id:mime-version :subject:cc:references:in-reply-to:from:organization:dkim-signature; bh=l/YtRHbaNxAvJJBbIoYtFy0sDOmcZWRbIs4MjOEQB/k=; b=SN3azV4UkeHNNJ5TFx7I11l+/AHISn1iGDhHuxsC88l69MJNl7hCY4OZRnkZNE3MrJ klIQu0mWaXxpR+5CjRuoFfa6cMzG0C7BoFuileEpee+TkxpCS461y/KGxRsrOCBEUyav dNXqZQzSPZbqLZ3ciecp0TVjcb2KZEwqhTVA1UjGU62ErKCdKhlpouYk/tjLV1okbPf+ 2gcr5zyDLmPqEdVDA5p5Jec1w3Uf7r7vR77z+jq4ZmYSBBqs4Vk8PyeB1cXcANAGLtSK 5h+kkTlDwrE7ZsTjxkqRzCR9PRJm3+uDagGdvjOz8b1gDnl7Z9/FBy01qJXEovZqTvps XgNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=L4G4pIxf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz20si2497661ejc.368.2021.04.09.09.04.04; Fri, 09 Apr 2021 09:04:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=L4G4pIxf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233784AbhDIQEG (ORCPT + 99 others); Fri, 9 Apr 2021 12:04:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24963 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232395AbhDIQEF (ORCPT ); Fri, 9 Apr 2021 12:04:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617984232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l/YtRHbaNxAvJJBbIoYtFy0sDOmcZWRbIs4MjOEQB/k=; b=L4G4pIxfNQlPNeBFgWcHoI42MmFSQTObajncLiWnWS4FKwGVjnm3sLu4olfsiCIOZ6DTPg 2Gvm1yU75OXAjJAMGic+VskPQAQtBeENUs5qRB5FJPxqe7NBbAmK4dydyjcoqTfZlMs1ed kHiUSN4RxYKnpAf/O/WJk+Jmv9UXZS4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-VKd9VOlPMEOH6PW381t7Pg-1; Fri, 09 Apr 2021 12:03:50 -0400 X-MC-Unique: VKd9VOlPMEOH6PW381t7Pg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54C20801814; Fri, 9 Apr 2021 16:03:48 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-119-35.rdu2.redhat.com [10.10.119.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id E36435C1D5; Fri, 9 Apr 2021 16:03:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <625171.1617971734@warthog.procyon.org.uk> References: <625171.1617971734@warthog.procyon.org.uk> <20210409111636.GR2531743@casper.infradead.org> <161796595714.350846.1547688999823745763.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Matthew Wilcox , torvalds@linux-foundation.org, Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jlayton@kernel.org, hch@lst.de, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <838189.1617984218.1@warthog.procyon.org.uk> Date: Fri, 09 Apr 2021 17:03:38 +0100 Message-ID: <838190.1617984218@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org David Howells wrote: > add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191) > Function old new delta > iomap_write_end_inline - 128 +128 I can get rid of the iomap_write_end_inline() increase for my config by marking it __always_inline, thereby getting: add/remove: 1/2 grow/shrink: 15/15 up/down: 280/-530 (-250) It seems that the decision whether or not to inline iomap_write_end_inline() is affected by the switch to bool. David