Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp50054pxb; Wed, 14 Apr 2021 09:10:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwRPrk+j603HG0+J184KWlkUHZmuv/cGN1ob8YbpaTVRYVNT57WDpgN9bzK6WJ2hcRmaEb X-Received: by 2002:a50:f696:: with SMTP id d22mr5564426edn.320.1618416622393; Wed, 14 Apr 2021 09:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618416622; cv=none; d=google.com; s=arc-20160816; b=u7XtjZdoIZM4udc8KWx93eXogkWB44uHn4SzJ0IBB9otoPUQ8zax/JIyLlRzdslbOe FfMnubc7Rwq0ICDj8eJE5FQU4I9j+b/aTkcQ6PO8ZHlB+mfFuO8SvOsWIS9tW127xE7R YftarV+juVSeQU3jo5YdvvLbcqcckO/uXdImkLRsrJ5YPcnG1GEzOcD6aY8BjBZIO+Jp WoQoL3OEDAFwlGJfyATE5vsE5/JK5W7IlhG4DCeUjNupQAP6fFFFOLG4xjbiIJFTIDYV 4kjMQRLYdtrGGmFmGKKreKS+mxlO6kdVBY8ctMt6uglTYuWiPWBSuSo8p6mmVful2/8u eXwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=vQ8YuWzbHT8qSg8nS3dkCo2AMt2yG/2PW5pdVfjYrq8=; b=ImBKGovgkZJ/0dX+kDF0bb9IY0bCRV1LuXZuUTKJ4JWJygqUsSwRdh3U+Lqrdl+ELe 6UIgPy+INuawbdFMqg61tQmqxJ67tSvl18jc/JyO2Ioct7YyY6rVacW1X4Sb8WgINL+E Icfk3WF+9rWl6viHP7V/FX2K3/6RRbYbEWChfYp3K73qx2p8ZpgxGpsxlnckzFDiiPf2 9Bc+xRmh9NfgGIfRk3npFA9OqHjU475c6u9+tGjx0KQO4G3to4v7Yk701BP4NqDo3hs5 und0m5HgcwTwPsgpYfYHR5gdkJlbzbhwJ8q+1B3wERVFw0WakvbKtK0slcijON3WhaoE ZJCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tNJU3TSr; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si4743ede.206.2021.04.14.09.09.59; Wed, 14 Apr 2021 09:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tNJU3TSr; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351579AbhDNNok (ORCPT + 99 others); Wed, 14 Apr 2021 09:44:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:52158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351608AbhDNNoX (ORCPT ); Wed, 14 Apr 2021 09:44:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15973611AD for ; Wed, 14 Apr 2021 13:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618407842; bh=OWPmJrsTKWRdUD8G+7Nml5alyTR4bp8YbG1DHJ0N5Nk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tNJU3TSrk4BOu15U6AHlkhhIyJ/BqEui+ZHTMMJCW/kGEgxl08v9gqjEFUeUPbjlw j0jh7Ozx0XIjwp3lFTQT0BbgzJFdOuSElcslBNWSouGlOszmHo7mliKRQ1wwuykIO4 IHol3JSiXhYncI7rzG7o5EIFVxlUkGBNce4vpJpaC4GpE+1R2unjXqW5MjE7gY+D+N 2Hkj+uSwr7yAZRC+WpeD50/X9fXi0+IQAL/Xds634kN/nTLXU+wIUuYqmtKgTWRDrN LuBjfcnJropq0eOo/Yuo8A/cx69kdsN1NKCULlxao7yhhqx0Bx2IEaQiTGfGBN2rw4 WrvVXpMRCrVBw== From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH v2 16/26] NFS: Remove a line of code that has no effect in nfs_update_inode() Date: Wed, 14 Apr 2021 09:43:43 -0400 Message-Id: <20210414134353.11860-17-trondmy@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210414134353.11860-16-trondmy@kernel.org> References: <20210414134353.11860-1-trondmy@kernel.org> <20210414134353.11860-2-trondmy@kernel.org> <20210414134353.11860-3-trondmy@kernel.org> <20210414134353.11860-4-trondmy@kernel.org> <20210414134353.11860-5-trondmy@kernel.org> <20210414134353.11860-6-trondmy@kernel.org> <20210414134353.11860-7-trondmy@kernel.org> <20210414134353.11860-8-trondmy@kernel.org> <20210414134353.11860-9-trondmy@kernel.org> <20210414134353.11860-10-trondmy@kernel.org> <20210414134353.11860-11-trondmy@kernel.org> <20210414134353.11860-12-trondmy@kernel.org> <20210414134353.11860-13-trondmy@kernel.org> <20210414134353.11860-14-trondmy@kernel.org> <20210414134353.11860-15-trondmy@kernel.org> <20210414134353.11860-16-trondmy@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust Commit 0b467264d0db ("NFS: Fix attribute revalidation") changed the way we populate the 'invalid' attribute, and made the line that strips away the NFS_INO_INVALID_ATTR bits redundant. Signed-off-by: Trond Myklebust --- fs/nfs/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 18c7277d17a8..e4333b6ab2d4 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -2110,7 +2110,6 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr) /* Update attrtimeo value if we're out of the unstable period */ if (attr_changed) { - invalid &= ~NFS_INO_INVALID_ATTR; nfs_inc_stats(inode, NFSIOS_ATTRINVALIDATE); nfsi->attrtimeo = NFS_MINATTRTIMEO(inode); nfsi->attrtimeo_timestamp = now; -- 2.30.2