Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] NFSD: Fix warning unused SSC variables from kernel
 test robot.
Thread-Topic: [PATCH 1/1] NFSD: Fix warning unused SSC variables from kernel
 test robot.
Thread-Index: AQHXNWQBx2D73VuHJEqJuBKG6jJsf6q8XmYA
Date:   Mon, 19 Apr 2021 21:40:19 +0000
Message-ID: <65AE91F6-1BFD-4936-9385-D75B7ACABDAB@oracle.com>
References: <20210419213556.75204-1-dai.ngo@oracle.com>
In-Reply-To: <20210419213556.75204-1-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FC9D11825CBD324BB6B85225681E47A3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 18dd8f0b-c923-46ea-85ce-08d9037bba5e
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 21:40:19.1466
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LWa8yx8LVAwxT2hA6MiYg8uQoKf8/hB3MaX3O7LTOeLCy+dpSrq89xXpuFwWkTiI8GHB4k3b/izlvVy96ikx9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5471
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9959 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 bulkscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104190147
X-Proofpoint-GUID: DXMBXhmky4XutE-Gk_Qv7h8CpGpXtFFe
X-Proofpoint-ORIG-GUID: DXMBXhmky4XutE-Gk_Qv7h8CpGpXtFFe
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9959 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 phishscore=0 mlxscore=0
 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 bulkscore=0
 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104190147
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hello Dai-

> On Apr 19, 2021, at 5:35 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> Compiler warning unused variables when NFS_V4_2 is configured and
> NFSD_V4 is not:
>=20
> fs/nfs/super.c:90:40: warning: unused variable 'nfs_ssc_clnt_ops_tbl'
> static const struct nfs_ssc_client_ops nfs_ssc_clnt_ops_tbl =3D {
>=20
> fs/nfs/nfs4file.c:410:41: warning: unused variable 'nfs4_ssc_clnt_ops_tbl=
'
> static const struct nfs4_ssc_client_ops nfs4_ssc_clnt_ops_tbl =3D {
>=20
> Fix by moving nfs_ssc_clnt_ops_tbl and nfs4_ssc_clnt_ops_tbl to
> under NFSD_V4 since they are only used when NFSD_V4 is configured.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
> fs/nfs/nfs4file.c | 2 ++
> fs/nfs/super.c    | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)

I think because these are client-side source files, the patch
should go to Trond.


> diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
> index 441a2fa073c8..400c8db05808 100644
> --- a/fs/nfs/nfs4file.c
> +++ b/fs/nfs/nfs4file.c
> @@ -313,6 +313,7 @@ static loff_t nfs42_remap_file_range(struct file *src=
_file, loff_t src_off,
> 	return ret < 0 ? ret : count;
> }
>=20
> +#ifdef CONFIG_NFSD_V4
> static int read_name_gen =3D 1;
> #define SSC_READ_NAME_BODY "ssc_read_%d"
>=20
> @@ -411,6 +412,7 @@ static const struct nfs4_ssc_client_ops nfs4_ssc_clnt=
_ops_tbl =3D {
> 	.sco_open =3D __nfs42_ssc_open,
> 	.sco_close =3D __nfs42_ssc_close,
> };
> +#endif	/* CONFIG_NFSD_V4 */
>=20
> /**
>  * nfs42_ssc_register_ops - Wrapper to register NFS_V4 ops in nfs_common
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 94885c6f8f54..a7af01bad344 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -86,7 +86,7 @@ const struct super_operations nfs_sops =3D {
> };
> EXPORT_SYMBOL_GPL(nfs_sops);
>=20
> -#ifdef CONFIG_NFS_V4_2
> +#ifdef CONFIG_NFSD_V4
> static const struct nfs_ssc_client_ops nfs_ssc_clnt_ops_tbl =3D {
> 	.sco_sb_deactive =3D nfs_sb_deactive,
> };
> --=20
> 2.9.5
>=20

--
Chuck Lever