Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3107877pxb; Tue, 20 Apr 2021 00:16:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcQY/RvrarCFg4fDV39aKCV8x72Rr4tbzwunX4m8vZAHkGuh/xcioWILjfQx6+66ofscLK X-Received: by 2002:a05:6402:27d3:: with SMTP id c19mr30810714ede.129.1618902969154; Tue, 20 Apr 2021 00:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618902969; cv=none; d=google.com; s=arc-20160816; b=DwA34wzPv/fXS270SrRxzfD53wo3q0G/G5hgqswyiyk1/mxDfpIHcAtcO1CVRVewKC zplqlqxSaoWgLQHSHvGqyJmbrZqO8p5KmYZuY+tyBjJ6BV4gzuOZcDKhlPzca0wtMsfk ph5shlQPVq9aSN6/YqMuug4A4xM9TbRE5EKmw/YiJ5O/i43FS+a4XTIIWaDunHAiZhS6 IvqBxwxy85jetZJ5hfG1HrkubGPDJRX4x2zDO4BVGBLI0VFdKW5000BYA2Oe5k0Sb+3f 7PD8Z5FxwZq3ArNka2IJKH3aMth7MscOVccPB8ouigEQ6/Qac4uBqPL3z+l6ug0vm6Vc TBDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9Y2k9wW87yD97dgH0io1J9x9gwe882Cl6puiapWthUw=; b=BznASyOUVk6h1NWIMg32ZgtyLrAXrYiZGhc/K776rvW7aDyuF5bxdB579K9Yo1LbwV PLtVSwitNA/T3Bm0SRIHAM4rggwx7Ffk3s8debAKGadYpWI1IKpCkbC5qwrarjLDPSzH XFZsSakNQX+kcqnsNkbC1swtp2ESpMegN2ePBnbIq2NommG7hKcvbkwqoKoG2dOb8wUi Dw5s7+IR342hdJekt0fws8zd68WWXaQgzDzcMXGKj6WZZBi+oqCBIjr9b1VQyHdrjF+t jcYQ3wEaNhXEVF+wEHEEc2eJnMwmJXLNZjtUYOqVu+66DkRfmlo5Ag/yWPFuqt3PZP7D erZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Au/EvSiy"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si13077901edr.168.2021.04.20.00.15.38; Tue, 20 Apr 2021 00:16:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Au/EvSiy"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230383AbhDTHP7 (ORCPT + 99 others); Tue, 20 Apr 2021 03:15:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:54006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbhDTHP5 (ORCPT ); Tue, 20 Apr 2021 03:15:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05A8460FF1; Tue, 20 Apr 2021 07:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618902926; bh=fvjxsgoBx7JGOSJaXoytegpfNSuCdjkRujjIoQ/GmLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au/EvSiy2VjwAs3jsJtgXlE2wnUl8vpgPUa8PDRRCTQnOLdPW9G1tL5z+IpLyZ8K8 zUzRxogqhqX0TUXtc0aftJJuhSb3Xkgn3kfhnKpT48B9A6nSs6cD3BRE+p4ChwY5Yb 3ja2PiFu25Lk0YfsNPUtYoBIIvh8si+nYUv06puk= Date: Tue, 20 Apr 2021 09:15:23 +0200 From: Greg KH To: Aditya Pakki Cc: "J. Bruce Fields" , Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , Dave Wysochanski , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SUNRPC: Add a check for gss_release_msg Message-ID: References: <20210407001658.2208535-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407001658.2208535-1-pakki001@umn.edu> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. > > Signed-off-by: Aditya Pakki > --- > net/sunrpc/auth_gss/auth_gss.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index 5f42aa5fc612..eb52eebb3923 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -848,7 +848,8 @@ gss_pipe_destroy_msg(struct rpc_pipe_msg *msg) > warn_gssd(); > gss_release_msg(gss_msg); > } > - gss_release_msg(gss_msg); > + if (gss_msg) > + gss_release_msg(gss_msg);a If you look at the code, this is impossible to have happen. Please stop submitting known-invalid patches. Your professor is playing around with the review process in order to achieve a paper in some strange and bizarre way. This is not ok, it is wasting our time, and we will have to report this, AGAIN, to your university... greg k-h