Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1200291pxy; Thu, 29 Apr 2021 01:42:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/HflXUSHB285IJlpUhcdHWpnsCinJbPmjtu9a0XpGOmb0fuQ1mZLsmt9AH7ydU0U0AST9 X-Received: by 2002:a17:907:2663:: with SMTP id ci3mr6796092ejc.540.1619685745990; Thu, 29 Apr 2021 01:42:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619685745; cv=none; d=google.com; s=arc-20160816; b=xq5+UM7bMCUrL6ryq7Qdh9i3ueCC0iGV4W+Gfr4L5PO4Z/jZo2oqixzJt10pDnwSiJ paTtYfZqXoYDPBYiX/VBsyI2Br+vu8MGTzlEOsQ0DxlQXf0/wwp2tiPB5tDiSzZfXTo2 8uQMWENwIS81MySrZpf9DwyawdTTy0vqvL/M815+M+CZywDq9+nZYBqOb9SAHjnADxfm mYzMG1jBA9MRmXUvJnIq4WRPYxaqHxS4CKDmcUA161JKiLyIRNEvbDISTNm3ZDLCl4No 4PtGHQqjtYgFQYkPGhc+nfyF9XfVrK6JSyhhgZhWL/2KusibG7qS1ElmLHxh9RUJ7XLK uIGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=nhLq7LUYLoOj4b9P22BfA2y71v1kgsQwevldanfEtCY=; b=0DzOvlqYFIPYSKEq988skCSKw5OzkZmXXz0fZvB+otR4W7+xi7EMiMmYqihKJUv/SJ iVTeN19FYKtkm9G9cCjT9TtoYcf8yXAqPpJy2xtHuPe4LPPorcMrnOtR5MCy6g17GmGV e+7T+wZNboctAZ4MrP6jdkAtGSm4IhFwh8h8PDaoEX44YeRHIjTvRihF8Poqze/0Fxbd WUc9sIRswxl+7umtB3h35Fy00ws+6eTJaeWxhyVFxtMwDKdTwYap9aCYDPNZjgHwwk4W 8l36OqYpdpuD69QT6d8cqryV2L62yrwDLJur3xIC+yQpSkriNsTbDKgnM1rMjynaApUX 2xNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jTcgpuDn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si2215977edy.531.2021.04.29.01.41.57; Thu, 29 Apr 2021 01:42:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jTcgpuDn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233264AbhD2Imk (ORCPT + 99 others); Thu, 29 Apr 2021 04:42:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34356 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhD2Imj (ORCPT ); Thu, 29 Apr 2021 04:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619685709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nhLq7LUYLoOj4b9P22BfA2y71v1kgsQwevldanfEtCY=; b=jTcgpuDnMaor46sSjvHYYNJDkotn5CANnA3B7HOJsOmkKq1KwWuxE8MshpgjQayg07Iy+b oB3PgHRBqZ67mLdaBWEAioR4VwXg3FxGpGZtzbWKBkANn/ohqxE+Npl01Ag0ko0A0hsVBr NMe6UIb5HRS+KxarcOFsu0w7WWF4Yfc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-pgMPVsLoOwWuQOuEz2kDFQ-1; Thu, 29 Apr 2021 04:41:47 -0400 X-MC-Unique: pgMPVsLoOwWuQOuEz2kDFQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B34C9F933; Thu, 29 Apr 2021 08:41:45 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-20.rdu2.redhat.com [10.10.112.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 928387012B; Thu, 29 Apr 2021 08:41:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <161918446704.3145707.14418606303992174310.stgit@warthog.procyon.org.uk> <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> To: Geert Uytterhoeven Cc: dhowells@redhat.com, Linux FS Devel , Marc Dionne , Linux MM , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, "open list:NFS, SUNRPC, AND..." , linux-cifs@vger.kernel.org, ceph-devel , V9FS Developers , Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , David Wysochanski , "Matthew Wilcox (Oracle)" , Alexander Viro , Linux Kernel Mailing List Subject: Re: [PATCH v7 07/31] netfs: Make a netfs helper module MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <442392.1619685697.1@warthog.procyon.org.uk> Date: Thu, 29 Apr 2021 09:41:37 +0100 Message-ID: <442393.1619685697@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Geert Uytterhoeven wrote: > I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this > is just a library of functions, to be selected by its users, then please > make the symbol invisible. Ideally, yes, it would be an invisible symbol enabled by select from the network filesystems that use it - but doing that means that you can't choose whether to build it in or build it as a module. David