Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     David Wysochanski <dwysocha@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC 06/21] NFSD: Remove spurious cb_setup_err tracepoint
Thread-Topic: [PATCH RFC 06/21] NFSD: Remove spurious cb_setup_err tracepoint
Thread-Index: AQHXRbR+jw8deaWN10q4PECm07TfIKrdKlaAgAAAnwA=
Date:   Mon, 10 May 2021 20:29:32 +0000
Message-ID: <42BBD4E8-7254-4ADB-98C5-84DE7AE1C9DC@oracle.com>
References: <162066179690.94415.203187037032448300.stgit@klimt.1015granger.net>
 <162066193457.94415.10829735588517134118.stgit@klimt.1015granger.net>
 <20210510202719.GB11188@fieldses.org>
In-Reply-To: <20210510202719.GB11188@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D248FF2129317247AB48B465EF12BA63@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 599dc4cd-b703-417a-96e3-08d913f2521b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 20:29:32.9183
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3WE+yRfLv0nfzzVtxG6Bktl91fI5ozv941BKaGKhUQZd9HWBBrf/kIvGMpG+PJVBIqxfQ8OfeP0XOeqggPKINA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4162
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105100140
X-Proofpoint-GUID: WrnMSQkuE18l-906pm3B_-2p_1Zdrcrw
X-Proofpoint-ORIG-GUID: WrnMSQkuE18l-906pm3B_-2p_1Zdrcrw
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 priorityscore=1501
 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0
 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105100139
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 10, 2021, at 4:27 PM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> On Mon, May 10, 2021 at 11:52:14AM -0400, Chuck Lever wrote:
>> This path is not really an error path,
>=20
> What's the non-error case for this path?

From what I can tell, it appears to be the default exit for when
there is a session and backchannel. Feel free to straighten me
out, but it just seemed to always fire for NFSv4.1 mounts.


> On a quick look it seems like that'd mean a 4.1 client doesn't have a
> connection available for the backchannel, which sounds bad.
>=20
> But I'm probably overlooking something....
>=20
> --b.
>=20
>> so the tracepoint I added
>> there is just noise.
>>=20
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>> fs/nfsd/nfs4callback.c |    4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>=20
>> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
>> index ab1836381e22..15ba16c54793 100644
>> --- a/fs/nfsd/nfs4callback.c
>> +++ b/fs/nfsd/nfs4callback.c
>> @@ -915,10 +915,8 @@ static int setup_callback_client(struct nfs4_client=
 *clp, struct nfs4_cb_conn *c
>> 		args.authflavor =3D clp->cl_cred.cr_flavor;
>> 		clp->cl_cb_ident =3D conn->cb_ident;
>> 	} else {
>> -		if (!conn->cb_xprt) {
>> -			trace_nfsd_cb_setup_err(clp, -EINVAL);
>> +		if (!conn->cb_xprt)
>> 			return -EINVAL;
>> -		}
>> 		clp->cl_cb_conn.cb_xprt =3D conn->cb_xprt;
>> 		clp->cl_cb_session =3D ses;
>> 		args.bc_xprt =3D conn->cb_xprt;
>>=20

--
Chuck Lever