Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4627597pxj; Wed, 12 May 2021 09:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQDLhMI+nk1xta2RxeShVhOTWOtDdekyQGvSF2S6PZtlITxKsE6LRQZUX/jjEO+IYK0tkp X-Received: by 2002:a05:6512:1192:: with SMTP id g18mr25829569lfr.659.1620837177067; Wed, 12 May 2021 09:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620837177; cv=none; d=google.com; s=arc-20160816; b=qJ47Fh07d5WHb9KlMmvR8PDEnQ0AjfW93zjioSAOc/4rig07yUfJB3iPeExWmXTIE8 yXb+tjoxAJ0L2bH8sQ9qvC6QnJe4yPLszt9m/ZLZRuBbYR0SKLu1ujbl3k/1qfGFd2aR zrXpr+///nUe22+C+NQ5IPliJ+2EyNw3d3YQ4cttbGxp1M7Ayl33f9kbV0OSwcTzkEGQ 8aGDlCU2JhdwqOe25LbLcY30oqLMIo2EEu/dlS7Hzjhhx0n+Bmz2TnNDeo1Ao+urWnBd fwQMgREr/AHV/2EA8nrt26JGA+nMyhZvGGV+vMZJlMZgUcE5b6y++f4lboq9h3gfD7aN 1MaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=R5mRHIZZTt/WoWwTQwBdkxv1ttOmhv0wQRji6d22C6A=; b=ay1jgAnbzqOo50o8UTutRJi9vDcL6lnASdW0RZC8VY6keh10aTaotMpVG7VZBLWGjq /Fu34w+uPX0EgNlJ8UmSKYwZuZwq0dELb5zn6eZOz1eI6hqTUqusoZm8wuCaLaSYjRUU 1UTwdwwbjl8R3rlRSjuMSNugJSIaq7Rqx7G6r0WePmaGcsjo1V4gQQm2fsEBh9GD/NrO /YZytR8LuitIne6vNu4m5hnJtpvzIK7tr1ZWd2hr39nS02BKMgyXP2lE5gCvJrud7c04 XJ8/EAO8nz8E+f2/e2RL4HbOTqabUyV5kuFzLkCk/mhaUut/C8Bo7srNbg1LsUgKtx41 CFAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si344230ljq.46.2021.05.12.09.32.17; Wed, 12 May 2021 09:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236548AbhELQcU (ORCPT + 99 others); Wed, 12 May 2021 12:32:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:34346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238698AbhELQGC (ORCPT ); Wed, 12 May 2021 12:06:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4FCF61955; Wed, 12 May 2021 15:34:56 +0000 (UTC) Subject: [PATCH v2 00/25] NFSD callback and lease management observability From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: dwysocha@redhat.com, bfields@fieldses.org, rostedt@goodmis.org Date: Wed, 12 May 2021 11:34:53 -0400 Message-ID: <162083366966.3108.12581818416105328952.stgit@klimt.1015granger.net> User-Agent: StGit/1.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org I've hacked together some improvements to the tracepoints that record server callback and lease management activity. I'm interested in review comments and testing. I'm sure I've missed your favorite edge case, so please let me know what it is! Changes since RFC: - Rebased firmly on v5.13-rc1 - Re-organized the SETCLIENTID/EXCHANGE_ID tracepoints - Fixed/replaced the use of '%.*s' - Re-ordered the series so those fixes come first In fact I'd like to submit the first 5 patches for v5.13-rc. --- Chuck Lever (25): NFSD: Fix TP_printk() format specifier in trace_nfsd_dirent() NFSD: Fix TP_printk() format specifier in nfsd_clid_class NFSD: Add nfsd_clid_cred_mismatch tracepoint NFSD: Add nfsd_clid_verf_mismatch tracepoint NFSD: Remove trace_nfsd_clid_inuse_err NFSD: Add nfsd_clid_confirmed tracepoint NFSD: Add nfsd_clid_reclaim_complete tracepoint NFSD: Add nfsd_clid_destroyed tracepoint NFSD: Add a couple more nfsd_clid_expired call sites NFSD: Add an RPC authflavor tracepoint display helper NFSD: Add tracepoints for SETCLIENTID edge cases NFSD: Add tracepoints for EXCHANGEID edge cases NFSD: Constify @fh argument of knfsd_fh_hash() NFSD: Capture every CB state transition NFSD: Drop TRACE_DEFINE_ENUM for NFSD4_CB_ macros NFSD: Add cb_lost tracepoint NFSD: Adjust cb_shutdown tracepoint NFSD: Remove spurious cb_setup_err tracepoint NFSD: Enhance the nfsd_cb_setup tracepoint NFSD: Add an nfsd_cb_lm_notify tracepoint NFSD: Add an nfsd_cb_offload tracepoint NFSD: Replace the nfsd_deleg_break tracepoint NFSD: Add an nfsd_cb_probe tracepoint NFSD: Remove the nfsd_cb_work and nfsd_cb_done tracepoints NFSD: Update nfsd_cb_args tracepoint fs/nfsd/nfs4callback.c | 45 ++++---- fs/nfsd/nfs4proc.c | 1 + fs/nfsd/nfs4state.c | 82 ++++++++----- fs/nfsd/nfsfh.h | 7 +- fs/nfsd/trace.h | 254 ++++++++++++++++++++++++++++++----------- 5 files changed, 264 insertions(+), 125 deletions(-) -- Chuck Lever