Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4679034pxj; Wed, 12 May 2021 10:42:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7kMwPYLSibTsiOA9lqe8GrpUHK2+ZQyCUW8t4l2sLNUhtyY6G2D9vDQ6LwKBQexTzN2Pt X-Received: by 2002:aa7:d543:: with SMTP id u3mr45368877edr.26.1620841349264; Wed, 12 May 2021 10:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620841349; cv=none; d=google.com; s=arc-20160816; b=iFrGYXsXOefwZ6AeGj45ldUk7+sivy99qtZ2P69xtoLycjO+BvMIBFRS10xdPpEWl5 9MKm9cZJQY5cT1jxJqpc+2Y9wOqaC+l/ELPBMwtYBvb/PX1EhOQma/biClLVVYB46Qqi PUpAdHtlneFxlRjhmD5RaK2quKNbk7xHbbqIaeyyRaSaEobOMTDE7KgDj1AWz2Z50SkW MX17wD39Z9/2qT62f7sNkK9GVhifw+fIZn+Aj08zd8y6uEpCoMpl+Mi7sKcJlpiod+OS 1gh+RVbLdf3rjIgf/zp6Lrh6sbk+6yUi1hJrTWwbwzGzsRiCOlZwjdNkE9wMgWOsA1lw J9FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=m9ja1TjE22m1+cVfuHyNKKc1b/E17B7dourSVqJhKJI=; b=RGtBMRbj24WoLzfanTf7OUnQ9eNT1Y2haERUKz4+V2fjHq0H8K6/LctOAGCRGije+t 9rEQZ7vpzm3meQgyHHhk+UHX1fc94KVH2oybyNBcS/ggqvo3IC3ZiiTB0/CgRmxanWV3 2lhhI0J6kMxjU/e7RID4PIs2ZHT76RyOdmj0VDczcn+GbK5CZJaNZEcZ0fQ+YTDp0TUA oGtYY+7haVy4k4xn1YvpVGcT3LtBRwStpPwWZWQiPhcy/Lr7cQa2s9Ovzq5ZO1IpMGAf cmMl58zvXXNaFuRQDP//G9JA8vKj1AHG185AG5cZu8U0c/kYs4Uojc9RhzBer00Zwdsu UYOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si563879ejv.384.2021.05.12.10.41.55; Wed, 12 May 2021 10:42:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231367AbhELRmz (ORCPT + 99 others); Wed, 12 May 2021 13:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244885AbhELQvV (ORCPT ); Wed, 12 May 2021 12:51:21 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E95F661002; Wed, 12 May 2021 16:26:24 +0000 (UTC) Date: Wed, 12 May 2021 12:26:23 -0400 From: Steven Rostedt To: Chuck Lever Cc: linux-nfs@vger.kernel.org, dwysocha@redhat.com, bfields@fieldses.org Subject: Re: [PATCH v2 01/25] NFSD: Fix TP_printk() format specifier in trace_nfsd_dirent() Message-ID: <20210512122623.79ee0dda@gandalf.local.home> In-Reply-To: <162083370248.3108.7424008399973918267.stgit@klimt.1015granger.net> References: <162083366966.3108.12581818416105328952.stgit@klimt.1015granger.net> <162083370248.3108.7424008399973918267.stgit@klimt.1015granger.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, 12 May 2021 11:35:02 -0400 Chuck Lever wrote: > Since commit 9a6944fee68e ("tracing: Add a verifier to check string > pointers for trace events"), which was merged in v5.13-rc1, > TP_printk() no longer tacitly supports the "%.*s" format specifier. Hmm, this looks like a bug. I should allow the %.*s notation. I probably should fix that. -- Steve