Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp272529pxj; Thu, 13 May 2021 04:44:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuKetXu/oSmelpE+lTTJ6f6drQtktqd5Filkt/MPiAXMUncSOd5FQh+vdSnKkwEo8ti97f X-Received: by 2002:a92:b111:: with SMTP id t17mr36483926ilh.208.1620906270149; Thu, 13 May 2021 04:44:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620906270; cv=none; d=google.com; s=arc-20160816; b=Q52GNTeqRwVB7rNw3SkXEhGmI0klSNKPDLXvmE6XDoPsD+D1REPiO462kA6/2qwh9u YwAuhfYfBa/COpI0BR8lI/U4gh/+ZtYrBsx4Z/VlxXjnZr4tB1L8ezPxGg1+Jrm/wi35 /QfcOiERYJgFYtRkwoEzyXpS6HYTU2CUkNvhCJLOX45pJ4/2+NnycwTAYM9sH0lv1h6c EFL0rvGy/jEnJiGwdwOYZIW6mebGw5KLJ/YTVOUhj3AI6yQ8cYjt8rzfjnVKa55iAeR8 X0ilh6qzT7VLyKCt7gH6XB15ilK3csjPL/MK5ezlAJMZShDaZZ6G8H6BEOMG35K566Nr 5Q6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:organization :dkim-signature; bh=hLTy2FqhYn8UYNDDx5zbQVMO+wFz0eJkwnkoKVTwuLc=; b=C6CX9t/L0QclPfZ4Ilp6v50jBeNZFePuEuwsXfKKirzWsJWtjeRI2pqZOng7rthvO/ WZNJkBpJa0oOp8bVjtathNtVDVq6iN02zvxtnLNhISLFTLLYspUQPP7+wyYVZm5Ncbdj hW7lwVcEDz4wtgGgNz7ytipvSWH9/Ss1HRoYX9NWC7k8l8Y6BWg65x2SpNiotziWWoZL nqNyQz+L9o2O0bRKTMm0+VmkrOx9AnoGVC7WXKIAgcHHpnUslFsEEpQ/8hWXB0LCLlRB 1ltuYBPYIhj6C4rkWoaU7GEg+4Q40F2tAy3+hkHynKv8K6tn2IHmDedAd7bjRdkDn720 ftDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LDFJGl8i; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j188si4041615jac.58.2021.05.13.04.44.07; Thu, 13 May 2021 04:44:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LDFJGl8i; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232063AbhEMKui (ORCPT + 99 others); Thu, 13 May 2021 06:50:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21341 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232052AbhEMKuf (ORCPT ); Thu, 13 May 2021 06:50:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620902965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hLTy2FqhYn8UYNDDx5zbQVMO+wFz0eJkwnkoKVTwuLc=; b=LDFJGl8ig44bfSqYsfrNVzW8l7+rRS/daKVBxp8jv0PTiiyPeOha+jKqbHLtdDNA1Cnv5e eJGK/FfjApBx3Zw6Cn+eaDzB6pk+Z71GUu7SsV+s0RGSoBWf1nSvRRt2KSNiONW09ooAVt TiamkzeBtA3lAiy5fNc+aNzQfyDHMwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-_zrl2b_yMqSu5EjZ_hHK9w-1; Thu, 13 May 2021 06:49:21 -0400 X-MC-Unique: _zrl2b_yMqSu5EjZ_hHK9w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0822B80DE1E; Thu, 13 May 2021 10:49:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9756919D7C; Thu, 13 May 2021 10:49:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH] netfs: Pass flags through to grab_cache_page_write_begin() From: David Howells To: willy@infradead.org Cc: linux-mm@kvack.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, dhowells@redhat.com Date: Thu, 13 May 2021 11:49:13 +0100 Message-ID: <162090295383.3165945.13595101698295243662.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org In netfs_write_begin(), pass the AOP flags through to grab_cache_page_write_begin() so that a request to use GFP_NOFS is honoured. Fixes: e1b1240c1ff5 ("netfs: Add write_begin helper") Reported-by: Matthew Wilcox (Oracle) Signed-off-by: David Howells cc: linux-mm@kvack.org cc: linux-cachefs@redhat.com cc: linux-afs@lists.infradead.org cc: linux-nfs@vger.kernel.org cc: linux-cifs@vger.kernel.org cc: ceph-devel@vger.kernel.org cc: v9fs-developer@lists.sourceforge.net cc: linux-fsdevel@vger.kernel.org --- fs/netfs/read_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/netfs/read_helper.c b/fs/netfs/read_helper.c index 193841d03de0..725614625ed4 100644 --- a/fs/netfs/read_helper.c +++ b/fs/netfs/read_helper.c @@ -1068,7 +1068,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping, DEFINE_READAHEAD(ractl, file, NULL, mapping, index); retry: - page = grab_cache_page_write_begin(mapping, index, 0); + page = grab_cache_page_write_begin(mapping, index, flags); if (!page) return -ENOMEM;