Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <69b577faaff376bde047edb9dfbda0b770ab0ca4.camel@kernel.org>
Subject: Re: [PATCH] netfs: Make CONFIG_NETFS_SUPPORT auto-selected rather
 than manual
From:   Jeff Layton <jlayton@kernel.org>
To:     David Howells <dhowells@redhat.com>, geert@linux-m68k.org
Cc:     linux-mm@kvack.org, linux-cachefs@redhat.com,
        linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org,
        linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
        v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Date:   Thu, 13 May 2021 11:14:45 -0400
In-Reply-To: <162090298141.3166007.2971118149366779916.stgit@warthog.procyon.org.uk>
References: <162090298141.3166007.2971118149366779916.stgit@warthog.procyon.org.uk>
Content-Type: text/plain; charset="ISO-8859-15"
User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-05-13 at 11:49 +0100, David Howells wrote:
> Make the netfs helper library selected automatically by the things that use
> it rather than being manually configured, even though it's required.
> 
> Fixes: 3a5829fefd3b ("netfs: Make a netfs helper module")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: linux-mm@kvack.org
> cc: linux-cachefs@redhat.com
> cc: linux-afs@lists.infradead.org
> cc: linux-nfs@vger.kernel.org
> cc: linux-cifs@vger.kernel.org
> cc: ceph-devel@vger.kernel.org
> cc: v9fs-developer@lists.sourceforge.net
> cc: linux-fsdevel@vger.kernel.org
> Link: https://lore.kernel.org/r/CAMuHMdXJZ7iNQE964CdBOU=vRKVMFzo=YF_eiwsGgqzuvZ+TuA@mail.gmail.com
> ---
> 
>  fs/netfs/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/netfs/Kconfig b/fs/netfs/Kconfig
> index 578112713703..b4db21022cb4 100644
> --- a/fs/netfs/Kconfig
> +++ b/fs/netfs/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
>  config NETFS_SUPPORT
> -	tristate "Support for network filesystem high-level I/O"
> +	tristate
>  	help
>  	  This option enables support for network filesystems, including
>  	  helpers for high-level buffered I/O, abstracting out read
> 
> 

Makes sense. No one is going to enable this w/o a fs that uses it, so
might as well make it automagic.

Reviewed-by: Jeff Layton <jlayton@kernel.org>