Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 May 2021 13:35:51 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc:     Dai Ngo <dai.ngo@oracle.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trondmy@hammerspace.com>,
        Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v5 1/2] NFSD: delay unmount source's export after
 inter-server copy completed.
Message-ID: <20210518173551.GA26957@fieldses.org>
References: <20210517224330.9201-1-dai.ngo@oracle.com>
 <20210517224330.9201-2-dai.ngo@oracle.com>
 <CAN-5tyGYhmy_dgKV_7xuPFJjyY_wsjDcun_TrDK_vidmVG1ZXg@mail.gmail.com>
 <20210518172334.GC25205@fieldses.org>
 <CAN-5tyG2pcduQAWJDaP83VgqK7QfsnoDZJe-JG=Oqdgj4PjSUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAN-5tyG2pcduQAWJDaP83VgqK7QfsnoDZJe-JG=Oqdgj4PjSUg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Tue, May 18, 2021 at 01:31:11PM -0400, Olga Kornievskaia wrote:
> On Tue, May 18, 2021 at 1:23 PM J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Tue, May 18, 2021 at 01:16:56PM -0400, Olga Kornievskaia wrote:
> > > General question to maybe Bruce: can nfsd_net go away while a compound
> > > is using it ?
> >
> > No.  Any server threads for that container should be shut down before
> > nfsd_net goes away.
> 
> Right, sorry but the async copy is a task that works after the
> compound of copy.

OK, I thought you were talking about normal compound processing from
server threads.

> You say "threads .. should be shut down", who makes
> sure of that (meaning should async copy code make sure of it)?

Just looking at the code... nfsd4_shutdown_copy() is called when a
client is destroyed to stop any in-progress copies.

--b.