Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH nfs-utils 2/2] configure: check for rpc/rpc.h presence
To:     Roland Hieber <rhi@pengutronix.de>
Cc:     linux-nfs@vger.kernel.org
References: <20210525112729.29062-1-rhi@pengutronix.de>
 <20210525112729.29062-2-rhi@pengutronix.de>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <042d49ae-2c4a-7c51-7c71-755fb1351905@RedHat.com>
Date:   Tue, 25 May 2021 14:08:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210525112729.29062-2-rhi@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/25/21 7:27 AM, Roland Hieber wrote:
> Recent versions of glibc (since 2.26?) no longer supply rpc/rpc.h, and
> in previous versions, RPC was optional. Detect such cases and prompt the
> user to build with libtirpc instead.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
Committed... (tag: nfs-utils-2-5-4-rc5)

steved.
> ---
>  configure.ac | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index f2e1bd30d0f2..25e988dfa33c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -335,6 +335,13 @@ AC_CHECK_HEADERS([sched.h], [], [])
>  AC_CHECK_FUNCS([unshare fstatat statx], [] , [])
>  AC_LIBPTHREAD([])
>  
> +# rpc/rpc.h can come from the glibc or from libtirpc
> +nfsutils_save_CPPFLAGS="${CPPFLAGS}"
> +CPPFLAGS="${CPPFLAGS} ${TIRPC_CFLAGS}"
> +AC_CHECK_HEADER(rpc/rpc.h, ,
> +                AC_MSG_ERROR([Header file rpc/rpc.h not found - maybe try building with --enable-tirpc]))
> +CPPFLAGS="${nfsutils_save_CPPFLAGS}"
> +
>  if test "$enable_nfsv4" = yes; then
>    dnl check for libevent libraries and headers
>    AC_LIBEVENT
>