Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Dave Wysochanski <dwysocha@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] nfsd4: Expose the callback address and state of
 each NFS4 client
Thread-Topic: [PATCH v2 1/1] nfsd4: Expose the callback address and state of
 each NFS4 client
Thread-Index: AQHXS1tmCnfOmKUeiUOn5lw8NnBzfKr0usmAgAAN74A=
Date:   Tue, 25 May 2021 21:48:38 +0000
Message-ID: <6C2F8C95-E29F-4BB3-9127-6ED5D825ACB7@oracle.com>
References: <1621283385-24390-1-git-send-email-dwysocha@redhat.com>
 <1621283385-24390-2-git-send-email-dwysocha@redhat.com>
 <20210525205845.GB4162@fieldses.org>
In-Reply-To: <20210525205845.GB4162@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F2332B3E353D7F49B14E08DA3EF0949E@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ec263f76-4f0f-49fd-8a20-08d91fc6daba
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 21:48:38.1567
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Df0un01VDtoKaCGHqpodBiCeL1hq6OFIglcl5e+2TqCJbKK2SVidpUew1WAqBRItd9pE8kyx1Jsc4ok7UHshYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3718
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105250134
X-Proofpoint-ORIG-GUID: VBZiR4ozLmP5f1WFblyc6qtKQ4heSSL6
X-Proofpoint-GUID: VBZiR4ozLmP5f1WFblyc6qtKQ4heSSL6
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501
 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105250134
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 25, 2021, at 4:58 PM, Bruce Fields <bfields@fieldses.org> wrote:
>=20
> When I run trace-cmd report I get output like:
>=20
>  [nfsd:nfsd_cb_state] function cb_state2str not defined
>  [nfsd:nfsd_cb_shutdown] function cb_state2str not defined
>  [nfsd:nfsd_cb_probe] function cb_state2str not defined
>  [nfsd:nfsd_cb_lost] function cb_state2str not defined
>=20
> I don't know how this is supposed to work.  Is it OK for tracepoint defin=
itions
> to reference kernel functions if they're defined in the right way somehow=
?  If
> not, I don't know what the solution would be for sharing this--define a m=
acro
> that expands to the array literal and use that in both places?  Or maybe =
just
> live with the the redundancy.

Living with the redundancy is OK with me.


> --b.
>=20
> On Mon, May 17, 2021 at 04:29:45PM -0400, Dave Wysochanski wrote:
>> In addition to the client's address, display the callback channel
>> state and address in the 'info' file.  Define and use a common
>> function for this information that can be used by both callback
>> trace events and the NFS4 client 'info' file.
>>=20
>> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
>> ---
>> fs/nfsd/nfs4state.c |  2 ++
>> fs/nfsd/trace.c     | 15 +++++++++++++++
>> fs/nfsd/trace.h     |  9 ++-------
>> 3 files changed, 19 insertions(+), 7 deletions(-)
>>=20
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index b2573d3ecd3c..f3b8221bb543 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -2385,6 +2385,8 @@ static int client_info_show(struct seq_file *m, vo=
id *v)
>> 		seq_printf(m, "\nImplementation time: [%lld, %ld]\n",
>> 			clp->cl_nii_time.tv_sec, clp->cl_nii_time.tv_nsec);
>> 	}
>> +	seq_printf(m, "callback state: %s\n", cb_state2str(clp->cl_cb_state));
>> +	seq_printf(m, "callback address: %pISpc\n", &clp->cl_cb_conn.cb_addr);
>> 	drop_client(clp);
>>=20
>> 	return 0;
>> diff --git a/fs/nfsd/trace.c b/fs/nfsd/trace.c
>> index f008b95ceec2..6291b5d10824 100644
>> --- a/fs/nfsd/trace.c
>> +++ b/fs/nfsd/trace.c
>> @@ -2,3 +2,18 @@
>>=20
>> #define CREATE_TRACE_POINTS
>> #include "trace.h"
>> +
>> +const char *cb_state2str(const int state)
>> +{
>> +	switch (state) {
>> +	case NFSD4_CB_UP:
>> +		return "UP";
>> +	case NFSD4_CB_UNKNOWN:
>> +		return "UNKNOWN";
>> +	case NFSD4_CB_DOWN:
>> +		return "DOWN";
>> +	case NFSD4_CB_FAULT:
>> +		return "FAULT";
>> +	}
>> +	return "UNDEFINED";
>> +}
>> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
>> index 10cc3aaf1089..8908d48b2aa6 100644
>> --- a/fs/nfsd/trace.h
>> +++ b/fs/nfsd/trace.h
>> @@ -876,12 +876,7 @@
>> 	TP_printk("client %08x:%08x", __entry->cl_boot, __entry->cl_id)
>> )
>>=20
>> -#define show_cb_state(val)						\
>> -	__print_symbolic(val,						\
>> -		{ NFSD4_CB_UP,		"UP" },				\
>> -		{ NFSD4_CB_UNKNOWN,	"UNKNOWN" },			\
>> -		{ NFSD4_CB_DOWN,	"DOWN" },			\
>> -		{ NFSD4_CB_FAULT,	"FAULT"})
>> +const char *cb_state2str(const int state);
>>=20
>> DECLARE_EVENT_CLASS(nfsd_cb_class,
>> 	TP_PROTO(const struct nfs4_client *clp),
>> @@ -901,7 +896,7 @@
>> 	),
>> 	TP_printk("addr=3D%pISpc client %08x:%08x state=3D%s",
>> 		__entry->addr, __entry->cl_boot, __entry->cl_id,
>> -		show_cb_state(__entry->state))
>> +		cb_state2str(__entry->state))
>> );
>>=20
>> #define DEFINE_NFSD_CB_EVENT(name)			\
>> --=20
>> 1.8.3.1

--
Chuck Lever