Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp573681pxj; Thu, 3 Jun 2021 13:53:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmUEpjSChjLVy8SaAvcJYebN3UHFcJ+ig5NVJD1vus9NJmGW7tP4jd+eGHpOuv96WHgL4a X-Received: by 2002:a50:fc84:: with SMTP id f4mr1285441edq.252.1622753617998; Thu, 03 Jun 2021 13:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622753617; cv=none; d=google.com; s=arc-20160816; b=JLXtohlN1Jw0RxCs2dlRvlJH8Jow4fkq6hc40qo5S1+2XSnpVs1o32oKSFKVxeDTSi xiZEm1Qj3BX20sXPHysKh3Q9ckxEwjaEKHxstI1saH+xwo+3Tbt+dDU+Y+yR3nuR59hX ZP4wkCvPqI/DH4SBBcynRVXoueOg+cud0G2nsU3SQ+KrDbB9H4DlQpzv5Cpq2wl4Rgmf 6XXZc+GTVzIVHA4iFhHA/N6sS7aOH12XWRrCUB4LUMXWnDzhnyd6GVK7krVQoJ/9PedB 8hzjffzIQRJvHHi+lTCXBjUa8kDGVNdZX9rGxOD+NxJSpbLGn6upQCytFwAe8uO2IgHv ZOZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=RIDL1SfambuN1lTp7K7z+3fh4nJE/+qvC4994xiwPzE=; b=bQnhRquHFj2LUJKhGrz7wv3Vr1jd5ROmqEWTe9wCtGEkQM+kZ9u2sCgT3NbmkKXkRv afUr3fScwgHH/8q11W8AilQ8vOamJdGSaeVO+GytEHJr+n9xemOYMoLYRYJhmvfOJ8X7 yjTjN5KmJuuizImrG2Oft3BwS5SB3Xddp/O7KfMSSQER+qe4/5I5ZwiAFqgvCIpusGl5 74PPUKwd8FTTzsbBaNxV8RNRQ6kDLOXK4GnYbS5JD22xyO4RHNhZ2onimnwJhBVcBFBO pnnGJvNqS2cXyiOjqOPy9rURZeAIKqQo4zEUwDzCDkuNK7UbEHKTyNiRhZ7R1ZTaPl/M 3CCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si2894948eju.144.2021.06.03.13.53.14; Thu, 03 Jun 2021 13:53:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbhFCUxO (ORCPT + 99 others); Thu, 3 Jun 2021 16:53:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFCUxO (ORCPT ); Thu, 3 Jun 2021 16:53:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 140D361263; Thu, 3 Jun 2021 20:51:29 +0000 (UTC) Subject: [PATCH 09/29] lockd: Update the NLMv1 nlm_res arguments decoder to use struct xdr_stream From: Chuck Lever To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org Date: Thu, 03 Jun 2021 16:51:28 -0400 Message-ID: <162275348837.32691.4312188122466636960.stgit@klimt.1015granger.net> In-Reply-To: <162275337584.32691.3943139351165347555.stgit@klimt.1015granger.net> References: <162275337584.32691.3943139351165347555.stgit@klimt.1015granger.net> User-Agent: StGit/1.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Chuck Lever --- fs/lockd/xdr.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/fs/lockd/xdr.c b/fs/lockd/xdr.c index b59e02b4417c..911b6377a6da 100644 --- a/fs/lockd/xdr.c +++ b/fs/lockd/xdr.c @@ -299,6 +299,20 @@ nlmsvc_decode_unlockargs(struct svc_rqst *rqstp, __be32 *p) return 1; } +int +nlmsvc_decode_res(struct svc_rqst *rqstp, __be32 *p) +{ + struct xdr_stream *xdr = &rqstp->rq_arg_stream; + struct nlm_res *resp = rqstp->rq_argp; + + if (!svcxdr_decode_cookie(xdr, &resp->cookie)) + return 0; + if (!svcxdr_decode_stats(xdr, &resp->status)) + return 0; + + return 1; +} + int nlmsvc_encode_testres(struct svc_rqst *rqstp, __be32 *p) { @@ -379,17 +393,6 @@ nlmsvc_decode_reboot(struct svc_rqst *rqstp, __be32 *p) return xdr_argsize_check(rqstp, p); } -int -nlmsvc_decode_res(struct svc_rqst *rqstp, __be32 *p) -{ - struct nlm_res *resp = rqstp->rq_argp; - - if (!(p = nlm_decode_cookie(p, &resp->cookie))) - return 0; - resp->status = *p++; - return xdr_argsize_check(rqstp, p); -} - int nlmsvc_encode_void(struct svc_rqst *rqstp, __be32 *p) {