Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/3] don't collapse transports for the trunkable
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>,
        trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc:     linux-nfs@vger.kernel.org
References: <20210609215319.5518-1-olga.kornievskaia@gmail.com>
From:   Steve Dickson <steved@redhat.com>
Message-ID: <9657859a-7e65-0b38-a4c5-3f74d0bdc5e8@redhat.com>
Date:   Thu, 10 Jun 2021 09:32:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210609215319.5518-1-olga.kornievskaia@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey!

On 6/9/21 5:53 PM, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> This patch series attempts to allow for new mounts that are to the
> same server (ie nfsv4.1+ session trunkable servers) but different
> network addresses to use connections associated with those mounts
> but still use the same client structure.
> 
> A new mount options, "max_connect", controls how many extra transports
> can be added to an existing client, with maximum of 128 transports in
> total for either nconnect transports (which are multiple connections
> but to the same IP) or transports that are going to different network
> addresses.
I'm trying to figure out why this new mount option is needed...
What is it protecting? What am I missing?

Plus it needs to be documented....

steved.
> 
> Olga Kornievskaia (3):
>    SUNRPC query xprt switch for number of active transports
>    NFSv4 introduce max_connect mount options
>    NFSv4.1+ add trunking when server trunking detected
> 
>   fs/nfs/client.c             |  1 +
>   fs/nfs/fs_context.c         |  8 +++++++
>   fs/nfs/internal.h           |  2 ++
>   fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
>   fs/nfs/super.c              |  2 ++
>   include/linux/nfs_fs_sb.h   |  1 +
>   include/linux/sunrpc/clnt.h |  2 ++
>   net/sunrpc/clnt.c           | 13 +++++++++++
>   8 files changed, 70 insertions(+), 2 deletions(-)
>