Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210609215319.5518-1-olga.kornievskaia@gmail.com> <9657859a-7e65-0b38-a4c5-3f74d0bdc5e8@redhat.com>
In-Reply-To: <9657859a-7e65-0b38-a4c5-3f74d0bdc5e8@redhat.com>
From:   Olga Kornievskaia <olga.kornievskaia@gmail.com>
Date:   Thu, 10 Jun 2021 13:33:14 -0400
Message-ID: <CAN-5tyG6Hs3yt4+GPBA6_x-vCC5aj-WPk6+HtLsQS-d+NY2a_A@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] don't collapse transports for the trunkable
To:     Steve Dickson <steved@redhat.com>
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        linux-nfs <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 10, 2021 at 9:29 AM Steve Dickson <steved@redhat.com> wrote:
>
> Hey!
>
> On 6/9/21 5:53 PM, Olga Kornievskaia wrote:
> > From: Olga Kornievskaia <kolga@netapp.com>
> >
> > This patch series attempts to allow for new mounts that are to the
> > same server (ie nfsv4.1+ session trunkable servers) but different
> > network addresses to use connections associated with those mounts
> > but still use the same client structure.
> >
> > A new mount options, "max_connect", controls how many extra transports
> > can be added to an existing client, with maximum of 128 transports in
> > total for either nconnect transports (which are multiple connections
> > but to the same IP) or transports that are going to different network
> > addresses.
> I'm trying to figure out why this new mount option is needed...
> What is it protecting? What am I missing?

Hopefully comments on patch3 of this series can help you answer that.

> Plus it needs to be documented....

Indeed a man page patch is needed but I was waiting to get a more
commonly accepted version of the code before adding the man page
patch.

> steved.
> >
> > Olga Kornievskaia (3):
> >    SUNRPC query xprt switch for number of active transports
> >    NFSv4 introduce max_connect mount options
> >    NFSv4.1+ add trunking when server trunking detected
> >
> >   fs/nfs/client.c             |  1 +
> >   fs/nfs/fs_context.c         |  8 +++++++
> >   fs/nfs/internal.h           |  2 ++
> >   fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
> >   fs/nfs/super.c              |  2 ++
> >   include/linux/nfs_fs_sb.h   |  1 +
> >   include/linux/sunrpc/clnt.h |  2 ++
> >   net/sunrpc/clnt.c           | 13 +++++++++++
> >   8 files changed, 70 insertions(+), 2 deletions(-)
> >
>