Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Wang Yugui" <wangyugui@e16-tech.com>
Cc:     linux-nfs@vger.kernel.org
Subject: Re: any idea about auto export multiple btrfs snapshots?
In-reply-to: <20210615231318.F40F.409509F4@e16-tech.com>
References: <20210613115313.BC59.409509F4@e16-tech.com>,
 <162371103543.23575.13662722966178222587@noble.neil.brown.name>,
 <20210615231318.F40F.409509F4@e16-tech.com>
Date:   Thu, 17 Jun 2021 13:02:35 +1000
Message-id: <162389895501.29912.12470238090250719500@noble.neil.brown.name>
Precedence: bulk

On Wed, 16 Jun 2021, Wang Yugui wrote:
> Hi, NeilBrown
>=20
> > On Sun, 13 Jun 2021, Wang Yugui wrote:
> > > Hi,
> > >=20
> > > Any idea about auto export multiple btrfs snapshots?
> > >=20
> > > One related patch is yet not merged to nfs-utils 2.5.3.
> > > From:   "NeilBrown" <neilb@suse.de>
> > > Subject: [PATCH/RFC v2 nfs-utils] Fix NFSv4 export of tmpfs filesystems.
> > >=20
> > > In this patch, an UUID is auto generated when a tmpfs have no UUID.
> > >=20
> > > for btrfs, multiple subvolume snapshot have the same filesystem UUID.
> > > Could we generate an UUID for btrfs subvol with 'filesystem UUID' + 'su=
bvol ID'?
> >=20
> > You really need to ask this question of btrfs developers.  'mountd'
> > already has a special-case exception for btrfs, to prefer the uuid
> > provided by statfs64() rather than the uuid extracted from the block
> > device.  It would be quite easy to add another exception.
> > But it would only be reasonable to do that if the btrfs team told us how
> > that wanted us to generate a UUID for a given mount point, and promised
> > that would always provide a unique stable result.
> > This is completely separate from the tmpfs patch you identified.
>=20
> Thanks a lot for the replay.
>=20
> Now btrfs statfs64() return 8 byte unique/stable result.
>=20
> It is based on two parts.
> 1) 16 byte blkid of file system. this is uniq/stable between btrfs filesyst=
ems.
> 2) 8 byte of btrfs sub volume objectid. this is uniq/stable inside a
> btrfs filesystem.
>=20
> the code of linux/fs/btrfs
> static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf)
>=20
>     /* We treat it as constant endianness (it doesn't matter _which_)
>        because we want the fsid to come out the same whether mounted
>        on a big-endian or little-endian host */
>     buf->f_fsid.val[0] =3D be32_to_cpu(fsid[0]) ^ be32_to_cpu(fsid[2]);
>     buf->f_fsid.val[1] =3D be32_to_cpu(fsid[1]) ^ be32_to_cpu(fsid[3]);
>     /* Mask in the root object ID too, to disambiguate subvols */
>     buf->f_fsid.val[0] ^=3D
>         BTRFS_I(d_inode(dentry))->root->root_key.objectid >> 32;
>     buf->f_fsid.val[1] ^=3D
>         BTRFS_I(d_inode(dentry))->root->root_key.objectid;
>=20
>=20
> for nfs, we need a 16 byte UUID now.
>=20
> The best way I though:
> 16 byte blkid , math add 8 byte btrfs sub volume objectid.
> but there is yet no a simple/easy way to get the raw value of 'btrfs sub
> volume objectid'.

I'm a bit confused now.  You started out talking about snapshots, but
now you are talking about sub volumes.  Are they the same thing?

NFS export of btrfs sub volumes has worked for the past 10 years I
believe.

Can we go back to the beginning.  What, exactly, is the problem you are
trying to solve?  How can you demonstrate the problem?

NeilBrown


>=20
> A simple but good enough way:
> 1) first 8 byte copy from blkid
> 2) second 8 byte copy from btrfs_statfs()
> 	the uniq/stable of multiple subvolume inside a btrfs filesystem is kept.
>=20
> Best Regards
> Wang Yugui (wangyugui@e16-tech.com)
> 2021/06/15
>=20
>=20