Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp185985pxv; Thu, 24 Jun 2021 05:52:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxukRDK4u7EAQBRdI6L+oH2e8P6I3Ng+kGNlAB5pBvfEd9uVOmtULx5sP0Es618YFVhYbMN X-Received: by 2002:a6b:292:: with SMTP id 140mr4025016ioc.11.1624539176821; Thu, 24 Jun 2021 05:52:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624539176; cv=none; d=google.com; s=arc-20160816; b=SI8rhZDKs1ncxSB2nnjr1psUhsMuNxIULkP/UuYDdvWTs2mXzIsfDbX8/6kWCZMKbI iSVw6QUZ/Gb7Y1WbV2L8G1bgQFRZPh3LLbpuKuWoP5QLu7BFhF2uTgrFA05XvMrGWm39 ynhbAAtH44UztoKF8L7WXoSHvlxh2eRjAKKvZDjzZ388Q4BEEOqvTPh3wmhYYsDZyELp 2kiFxQmDWD7eexe/PxMeaimZOvWM4wZ4GEbb/oOXeUPY4L8+RquM93aq6wfNiAZdFwtE BVP7AqGwVQGYutItaAkbgFfx4kX3S7GjGBEFPgKM/EDK9UbYdSRZ343qlKuUy8omaScz LcDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JjqzPDjGNDhHumqGJMc0l3thrqr4HCxhcR5q9gXHRVI=; b=v0laY11PMN2SouhJUrGdzzLr0t8axa9Fk1DZPSRrrHTUf83+j/XGvTfGu7OaZbSCNf AXat5eUOGIGrf8unIuv2J1O8/Yr+g1gzME7Tel8Oe1Jy/0CTbS2UiZw3AeTeXKG6+HlF J8piTtfE1TRbAAIOLZC6josXUGe2Xb+v55dJsEWTm4Lzs77k5VmDnjMblI1zCHIuMJpG nTVx5YZVvmBlVHzxyNMJGT8w2Ei4wp0Xztkj2sfNAs+q7LgCxiV2wE79xrkGPoEDcJim 8I6pOG18RdVBrriknExgzByykGrwM1or3yT4vYHmH3c1XFxzWNAmsXQNuDAhTf/5qSV2 1K+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZHXFAOSc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k24si3794939jan.49.2021.06.24.05.52.34; Thu, 24 Jun 2021 05:52:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZHXFAOSc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbhFXMyS (ORCPT + 99 others); Thu, 24 Jun 2021 08:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbhFXMyR (ORCPT ); Thu, 24 Jun 2021 08:54:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E93BEC061574; Thu, 24 Jun 2021 05:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JjqzPDjGNDhHumqGJMc0l3thrqr4HCxhcR5q9gXHRVI=; b=ZHXFAOScAfgMoquJF+eOmfyt/0 u4lfdzcsYHoMIAVufKj0U1kRaUkZlD0/SEeeGgG1WIgHqH3tfofg9Co8DWV7+R6be80c+s8WJNklt TjiY0fQ4/m0tD6E3RT7YWEk6izmllQH7H/mLczr89FTJTSV+99T8L2r0Q53JsILuQ2n8tkeSLqcsn upkNqijoUF0LNd3ZagzBydpkgR9mrJ4d9PzTqvDk+fAkx2CVZC1KorUA4MU+68xsz7s16smj9seis 1B0oOcb5FekbmeNawc/jlqVtIg4dGOZQRLSMX9KCguiao0RXE0J3sGc03+iP+UKwFNaNHBHcyJFzb mcoEUyEw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOpH-00GaLw-B1; Thu, 24 Jun 2021 12:51:27 +0000 Date: Thu, 24 Jun 2021 13:51:23 +0100 From: Christoph Hellwig To: Gao Xiang Cc: linux-nfs@vger.kernel.org, LKML , Trond Myklebust , Anna Schumaker , Christoph Hellwig , Joseph Qi Subject: Re: [PATCH v2 1/2] nfs: fix acl memory leak of posix_acl_create() Message-ID: References: <1624430335-10322-1-git-send-email-hsiangkao@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624430335-10322-1-git-send-email-hsiangkao@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jun 23, 2021 at 02:38:54PM +0800, Gao Xiang wrote: > When looking into another nfs xfstests report, I found acl and > default_acl in nfs3_proc_create() and nfs3_proc_mknod() error > paths are possibly leaked. Fix them in advance. Looks fine, Reviewed-by: Christoph Hellwig