Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Dan Carpenter" <dan.carpenter@oracle.com>
Cc:     kbuild@lists.01.org,
        "Trond Myklebust" <trond.myklebust@hammerspace.com>,
        "Anna Schumaker" <Anna.Schumaker@Netapp.com>, lkp@intel.com,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH/rfc] NFS: introduce NFS namespaces.
In-reply-to: <202106252106.UEbAG2Yp-lkp@intel.com>
References: <162458475606.28671.1835069742861755259@noble.neil.brown.name>,
 <202106252106.UEbAG2Yp-lkp@intel.com>
Date:   Mon, 28 Jun 2021 10:14:13 +1000
Message-id: <162483925301.7211.5330261248734853509@noble.neil.brown.name>
Precedence: bulk

On Fri, 25 Jun 2021, Dan Carpenter wrote:
> Hi NeilBrown,
>=20
> url:    https://github.com/0day-ci/linux/commits/NeilBrown/NFS-introduce-NF=
S-namespaces/20210625-093359
> base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
> config: x86_64-randconfig-m001-20210622 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>=20
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

I assume this only applies if I fix the issue with a separate patch?

>=20
> New smatch warnings:
> fs/nfs/nfs4proc.c:6270 nfs4_init_uniform_client_string() error: we previous=
ly assumed 'clp->cl_namespace' could be null (see line 6247)
>=20
> Old smatch warnings:
> fs/nfs/nfs4proc.c:1382 nfs4_opendata_alloc() error: we previously assumed '=
c' could be null (see line 1350)
>=20
...
> 0575ca34891617 NeilBrown       2021-06-25 @6247  	if (clp->cl_namespace)
>                                                         ^^^^^^^^^^^^^^^^^^^=
^^^
> Checks for NULL

Thanks.  That was suppose to check the first byte of clp->cl_namespace,
not the pointer.

Thanks,
NeilBrown