Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Neil Brown <neilb@suse.de>,
        Trond Myklebust <trondmy@hammerspace.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Dai Ngo <dai.ngo@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: automatic freeing of space on ENOSPC
Thread-Topic: automatic freeing of space on ENOSPC
Thread-Index: AQHXbFawsxWIRQcUak231tyZr1/kZKsqJs8AgAAICQCAAAjfgIABGfiAgAAB5wA=
Date:   Tue, 29 Jun 2021 18:39:46 +0000
Message-ID: <20DE3A01-9B1D-4909-B347-65055CE4F86B@oracle.com>
References: <20210628194908.GB6776@fieldses.org>
 <9f1263b46d5c38b9590db1e2a04133a83772bc50.camel@hammerspace.com>
 <20210629011200.GA14733@fieldses.org>
 <162493102550.7211.15170485925982544813@noble.neil.brown.name>
 <20210629183257.GA1926@fieldses.org>
In-Reply-To: <20210629183257.GA1926@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m1+e7zyUfVPK6ejUoI6HZ4ulp3Run1laxfRgP31RDB7YSbm8tkqkRoJBgsTV?=
 =?us-ascii?Q?YKL1lSYgAGd0nZROhSE2Zn7MHPILvIZW5L0cPc0u4jf1DTXkrV6c8C/7Eemf?=
 =?us-ascii?Q?eX97ZUeBnKm8EmV+kRhh5100KG0M76RAMcgUKLhXl/mz8PEpDKa6V3cmEbYN?=
 =?us-ascii?Q?5F5TgAizagBH3Ece5ROhvFSM1BlPE2sERwDEmUz0S7Cql49WKNJ21HaypTIE?=
 =?us-ascii?Q?wqdoWLAPjpfzYFMOBFnsztylSOVhC6zV1Hs2k+Q7W23pXyhH4NliQOBaBKXV?=
 =?us-ascii?Q?BXa7bLQ6FQwNExcWoBcyQAdMyEcvucIJvNwuTtmBxmXo0qWLZ2elPKWYkdR7?=
 =?us-ascii?Q?KHGn6usyA1aTUlbOFGes/kiFy1G8wLTPlARpFqFrPlU1yx95Pvt9Dtz/odka?=
 =?us-ascii?Q?g+L1Ihg/iyu5C+Ui01cgghJ9oQRj77wf4et9Hf0696A0IcXQnvKsVvh9WxJL?=
 =?us-ascii?Q?yZH12bHbrO44eSZlnCYhuMCO2hcAVOTv1yVXTF8jBLiivliWMgS+y1jS2TTI?=
 =?us-ascii?Q?0fP6UMQPN8qchp0x1RcwWxJnKWf3uGYRI6ivxIh37XSPjVU0yPYWDBhcPTjl?=
 =?us-ascii?Q?WoQGCdRJL1HkgwUa8CmV1F7gmtOvxl329UHqBZrr7T3am3DkOeZi0bmzig4M?=
 =?us-ascii?Q?XBLl4wU+rrOEZV2KxdFI240Q/vDBJ5rVUoJ10OVkB013a50rTb8O6TXtXrdm?=
 =?us-ascii?Q?wMmREL7c67bP2bvyuRZGhIpC/thMA09zJDC68UTcQdineAhyTEWmDnCor87y?=
 =?us-ascii?Q?cd+JpwccEu3YLBi4uISBrYXBvXnnp9V5Hkn4seHJPTIGTo8SDNLEf4r9RW+B?=
 =?us-ascii?Q?bt6LvMx4y2V1sisaNnzhKfgeCi/dxGp1+0MshAVBFYB9wnW958lflmoTQJEt?=
 =?us-ascii?Q?dIcHGfXEsDccooauKTJcEpbLdMB5BQJxjVWqq9Meuy2Mewtbk3YgKFEc5ftK?=
 =?us-ascii?Q?eLN5c0Fsr2cHOaM1woC29qMSvPQoGVthHyShcQeRehqc26am1kKsEPHqdUCv?=
 =?us-ascii?Q?CXcNkSuePp3i9oosyh91wNCIPxGM/o6kwhXvWv7IpqgbePScdH26+9R7iW5o?=
 =?us-ascii?Q?1TZxs2ZnIxn6jLXrSIGgJuahEHOYWsEqL0JonfSNqMjSGxoaSBJQ2V62pVda?=
 =?us-ascii?Q?NgRH6oA0ku3EoC4NX659oqC3cd0Ezb1SHU71OCLfK3iGDuw1IXb3lyeUDxcb?=
 =?us-ascii?Q?OCQXfUDRJOYqz2hXKwLPaVAEo4FrfoWtx+1HoQXkdvcM+dy5Xc8/BLgRHIPS?=
 =?us-ascii?Q?5YTDHu3pptiKVjihtNZ0rOvHaHZgrEQXiEF0k8S3fzwp9fe+vufl3OvlCz2r?=
 =?us-ascii?Q?AWA7W0+tnVuX8yCNAniOcnMr?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F0627FA812C1D748BA77330DDBB5E978@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b945deac-ce62-4a02-cded-08d93b2d44f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 18:39:46.5340
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sriPrr/9G9gxXz7XXwawv/w/toXwDNRdB7Xmx4wU5AsSvoeRe2h4PhwFHbtBYUmJHvhrUpRrZemMprHDdABQ8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2757
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10030 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106290118
X-Proofpoint-ORIG-GUID: cEOv-O1TGpzfqGCTzS-MQ38Fz0kWyFz8
X-Proofpoint-GUID: cEOv-O1TGpzfqGCTzS-MQ38Fz0kWyFz8
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 29, 2021, at 2:32 PM, bfields@fieldses.org wrote:
>=20
> On Tue, Jun 29, 2021 at 11:43:45AM +1000, NeilBrown wrote:
>> I wonder how important this is.  If an NFS client unlinks a file that it
>> has open, it will be silly_renamed, and if the client then goes silent,
>> it might never be removed.  So we already theoretically have a
>> possibilty of ENOSPC due to silent clients.  Have we heard of this
>> becoming a problem?
>=20
> Oh, that's a good point.  I've seen complaints about sillyrename files,
> but I can't recall ever seen a single complaint about their causing
> ENOSPC.
>=20
>> Is there reason to think that the Courteous server changes will make
>> this problem more likely?=20
>=20
> So I guess the only new cases the courteous server will introduce are
> even less likely (probably just the case where a file is unlinked by a
> client other than the one that has it open).
>=20
> So I think doing nothing for now is an acceptable alternative....

I'm comfortable with that too. We can keep a careful eye on this
as the courteous server moves further along.

--
Chuck Lever